Last Week Archives

KDE-CVS-Digest

Weekly View of KDE CVS commits

October 31, 2003

By Derek Kite



This Week:

Feature freeze instituted for 3.2 release. Groupware support merged, sortof. Many bug fixes, including 'enter closes completion popup' in Konqueror.


Stephan Kulow announced a feature freeze in preparation for the beta1 release:

Just a friendly reminder: the cvs HEAD is frozen for features
and string changes.

Excluded from string freeze: pure bug fixes in the strings (e.g.
errors in the strings that would lead to user errors)
Not excluded: systematic style guide or grammar fixes (there was
enough time for that).

As usual: if you're in doubt, post your patch on kde-core-devel
(or kde-i18n-doc for string changes).

I'd welcome if you could shift your concentration on regressions
and bugs that have severity >= major in bugzilla (on your own
scale of course). There will always be bugs, so there is little point
risking new bugs while fixing not so important bugs :)

Release dudes can't be too friendly though. There was a commit of tips in KDevelop, and Stephan's response was curt: Revert. So what features didn't make it into this release? Some things that are close but not quite ready are listed here:

Kate BiDi support.
Merge kroupware branch to HEAD to make Kontact a fully functional Kolab client.
HTML mail composition support.
Full text index in KMail.

Regarding the groupware functionality, there was a flurry of activity days before the freeze. Reinhold Kainhofer, Cornelius Schumacher and Bo Thorsen worked out some details. Bo Thorsen was intent on this being part of the release, and committed this patch. Here is his comments from the kde-pim mailing list:

Here is the latest groupware patch. I fixed some issues with the free/busy 
handling, but it's still not good enough and I don't have any more time 
for coding today :-(

So I took the consequence and disabled all the configuration for now and 
put disabling guards on all the code. This means it is officially not 
supported, and the user has no way to get at this functionality. It is 
possible for developers to do so, though - either reenable the prefs page 
groupware checkbox or set "Use Groupware Communication=true" in the 
"Group Scheduling" configgroup in korganizerrc. When this setting is not 
present or false, there is no change in korganizer functionality. When it 
is set, the automatic groupware scheduling is working; the freebusy prefs 
page is shown; and the gantt view is in the event editor.

The idea with this is of course that I can commit the patch and work with 
incremental changes instead, and that others can start hacking away on 
the code. That way we can also discuss smaller and more separate issues 
than try and comment on a ~100KB patch. But still without giving the user 
the option of accessing it so no confusion will be made.

I'm sure someone will point out that since HEAD is now (or soon) frozen, 
there is no reason to accept this patch. But I fear that if it's not 
committed, then the last four days work will be lost, because I will be 
back to porting the patch to HEAD again when it opens.

And of course, if we do make a separate kdepim release anyway, it would be 
good to get this in.

He later added:

I just got a green light on checking in the gw patch, so it's in now :-)

Instructions on trying the stuff out:

Set "Use Groupware Communication=true" in the "Group Scheduling" 
configgroup in korganizerrc and restart korganizer.

So there you have it. The merge turned out to be a little more complicated than simply adding taking Kroupware code. There are a number of issues that need to be hashed out. The promise is that there will be a Kontact release in a few months with the groupware capability, and also Exchange support. Daniel Molkentin proposed:

1) Bo tries to get the groupware_branch in. We will sort out smaller issues 
later.
2) We will delay Exchange support to the release in two or three months. 
Contrary to groupware_branch, the concept of exchange support never has been 
really tested apart from Jan-Pascal. We might keep it as KOrganizer resource, 
though (we shipped it earlier anyways).
3) In order to prepare the independent KDE-PIM release, we should have another 
meeting asap.

Statistics

Commits:2039 by 199 developers, 375686 lines modified, 925 new files
Open bugs:4576
Open wishes:4748
Bugs opened:329 in the last 7 days
Bugs closed:480 in the last 7 days

CVS Commit Summary
ModuleCommits
kde-i18n 577
kdepim 186
kdelibs 174
kdenetwork 158
kdebase 150
kdeextragear-2 95
kdenonbeta 87
kdevelop 67
kdesdk 66
kdegraphics 62
CommitsDeveloperLines
98 Daniele Medri 1420
88 Stephan Binner 838
63 Stephan Kulow 4209
61 Laurent Montel 635
61 Stefan Asserhäll 4198
58 Malcolm Hunter 3819
54 David Faure 947
53 Scott Wheeler 1808
39 Erik K. Pedersen 11357
38 Martijn Klingens 2403
Internationalization Status
Danish (da)  99.10%
Serbian (sr)  96.22%
Hungarian (hu)  96.12%
Swedish (sv)  95.28%
Spanish (es)  93.15%
Brazilian Portuguese (pt_BR)  91.71%
Catalan (ca)  87.04%
Portuguese (pt)  86.93%
Estonian (et)  86.52%
Italian (it)  83.66%

Table of Contents


Application Features Optimize Security Bug Fixes
Development Tools new     fix
Graphics       fix
Kde-Base new opt   fix
Kde-Pim new     fix
Koffice       fix
Konqueror new     fix
Multimedia new opt   fix
Networking Tools new     fix
User Interface new     fix
Utilities       fix
Click on the icons to go to the respective section!

Development Tools

Features

Jonathan Riddell committed a change to kdesdk/umbrello/umbrello/codegenerators

Some improvements to PHP code generator from Fjey fjey-AT-email.cz
- strictly uses tabs for indenting
- better (more common) comments formating
- adds @access, @abstract, @static for member variables and/or functions
- adds types for @param and @return (@param <type>, @return <type>);
   unfortunatelly umbrello does not support comments for function return
+value, that's why only type for @return is provided
- some other minor (not important) changes.

Change by me:
- Use $this->attname  to access attributes, otherwise it's not accessing the clas attribute

Diff

Nicolas Deschildre committed a change to quanta/quanta

* The toolbars can now insert Elements which call others elements, e.g. adding
TABLE will add TR and then TD.
* A new default border value has been set for the borderless table.
* Possibility to add Tags which can't be inserted at the cursor position e.g. TD,
   TR, LI. Simply put the cursor on a child of the TABLE, OL, UL and then it will
   insert them.
 - Some cases to fix, like the insertion of TBODY.
* Set some usage="required" to childs in (x)html.
* Maybe others things...

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20,
21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37
Bugfixes

Stephan Binner committed a change to kdeaddons/kate/insertcommand

Bug 66858: TYPO: </p> missing in kdeaddons/kateinsertcommand.pot

Refer to Bug 66858 - TYPO: </p> missing in kdeaddons/kateinsertcommand.pot
Diff

Jesse Yurkovich committed a change to kdelibs/kate/data

* patch for SML by reporter of #66710
* dont choke on single quotes in XML highlighting

Refer to Bug 66710 - kate SML syntax highlighting should recognize string escapes
Diffs: 1, 2

Andras Mantia committed a change to kdelibs/kate/part

Hide completion comment if the user click somewhere in the document. Fixes Quanta bug 62118.

CCMAIL: 62118-done@bugs.kde.org

Refer to Bug 62118 - automatic completion words remain on screen
Diff

Jonathan Riddell committed a change to kdesdk/umbrello/umbrello

Fix setting operation and sequence number on collaboration diagrams.
Related to beastie 63897.

Refer to Bug 63897 - Crash when trying to associate two classes in a collaboration diagram
Diffs: 1, 2, 3, 4, 5, 6, 7

Jonathan Riddell committed a change to kdesdk/umbrello/umbrello

Fix beastie 66459
Class Generation Wizard doesn't add a class to the project

Refer to Bug 66459 - Class Generation Wizard doesn't add a class to the project
Diffs: 1, 2, 3

Jonathan Riddell committed a change to kdesdk/umbrello/umbrello

Revert commit which introduced beastie 66442:

--
*Make AssocRole and AssocPropPage take a UMLAssociation and not an AssociationWidget.

*Make AssogGenPage display all associations in which an object is involved, and not
  only the Widget Associations on the current diagrem
--

commit was http://lists.kde.org/?l=kde-cvs&m=106625824319912&w=2

Refer to Bug 66442 - When selecting the 'Activity Transition' properties on a right click Umbrello crashes
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14

Oliver Kellogg committed a change to kdesdk/umbrello/umbrello

Fix beastie 66848 (deleting message in seq.diagram caused crash.)

Refer to Bug 66848 - deleteing messages in sequence diagrams causes a crash
Diffs: 1, 2, 3

Oliver Kellogg committed a change to kdesdk/umbrello/umbrello

Clean out a residue of bug 66848 (thanks for noticing Jon.)

Refer to Bug 66848 - deleteing messages in sequence diagrams causes a crash
Diff

Amilcar do Carmo Lucas committed a change to kdevelop/buildtools

Usability fix

CCMAIL: 65348@bugs.kde.org

Refer to Bug 65348 - Feature Request: Need an 'Add external file to project' menu item.
Diffs: 1, 2

Amilcar do Carmo Lucas committed a change to kdevelop/buildtools/autotools

Fix Bug 65721: when running make install as root, run make as user before

CCMAIL: 65721-done@bugs.kde.org

Refer to Bug 65721 - when running make install as root, run make as user before.
Diff

Jens Dagerbo committed a change to kdevelop/parts/distpart

Fix for bug #61471.


Refer to Bug 61471 - gideon freezes on checking the rpmmacros file
Diff

Andras Mantia committed a change to quanta

Possible compilation fix for libxml2 2.6.x. Stephan, can you try it?
Also fix another "error dialos shows behind the splash screen" bug.

CCMAIL: 66732-done@bugs.kde.org
CCMAIL: binner@kde.org

Refer to Bug 66732 - quanta splash blocks error message
Diffs: 1, 2, 3, 4

Andras Mantia committed a change to quanta

Finish the "preview of noframes area" and close the report.

CCMAIL: 58458-done@bugs.kde.org

Refer to Bug 58458 - Non-Frames browser preview of frames pages
Diffs: 1, 2, 3, 4, 5, 6

Andras Mantia committed a change to quanta/quanta

Change attr & tag case functionality.

CCMAIL: 55322-done@bugs.kde.org

Refer to Bug 55322 - For case sensitive DTD's, have option to automatically convert elements to specified case
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11

Andras Mantia committed a change to quanta/quanta

Non-GUI option in quantarc to disable the addition of Home & Root foolders to the
files tree. In [General Options] put: Home-Root Folder On = false.

CCMAIL: 63609-done@bugs.kde.org
CCMAIL: quanta-devel@kde.org

Refer to Bug 63609 - hardcoded folders in filetree
Diff

Graphics

Bugfixes

Klaas Freitag committed a change to kdegraphics/kooka

CCMAIL: 66711-close@bugs.kde.org

The bug described in #66711 is probably the effect of the problems in
thumbview described by Waldo some time ago (see below).
This patch fixes both problems.

    1) KDirLister is the owner of the KFileItems it emits, this means
       that you must watch it's deleteItem() signal vigourously,
       otherwise you may end up with KFileItems that are already
       deleted. This burden is propagated to classes that use
       KDirLister, such as KFileIconView.

       This has a tendency to go wrong in combination with PreviewJob,
       because it stores a list of KFileItems while running. This has
       the potential to crash if the fileitems are being deleted
       during this time. The remedy is to make sure to remove
       fileitems that get deleted from the PreviewJob with
       PreviewJob::removeItem.

    2) I think you may end up creating two PreviewJob's in parallel
       when the slNewFileItems() function is called two times in
       quick succession. The current code doesn't seem to expect
       that, given the comment in slPreviewResult(). In the light of
       1) it might become fatal since you will not be able to call
       PreviewJob::removeItem on the proper job. I suggest to queue
       new items when a job is already running and start a new job
       once the first one is finished when there are any items left
       in the queue. Don't forget to delete items from the queue if
       they get deleted in the mean time.

       The strategy is as follows: In the global list m_pendingJobs
       the jobs to start are appended. Only if m_job is zero (no job
       is running) a job is started on the current m_pendingJobs list.
       The m_pendingJobs list is clear afterwords.

Refer to Bug 66711 - Kooka crashes on gallery operations
Diffs: 1, 2

Kde-Base

Features

Kurt Pfeifle committed a change to kdelibs/kdeprint

- more "WhatsThis" items for kprinter (danimo told be there's a "string
  freeze" from sometime this weekend, so I better commit, even if I have
  not done all I wanted...)

Diffs: 1, 2, 3, 4, 5, 6
Optimizations

Bo Thorsen committed a change to kdebase/kioslave/imap4

Fix dIMAP speed issues

Diffs: 1, 2
Bugfixes

David Faure committed a change to kdebase

Fixed misbehaving F10 action ("create directory").
* It wasn't available before the popupmenu was opened
* AND it wouldn't create the new dir in the current dir, but in the last dir
where the popupmenu was opened !!!
-> there's now (again?) a separate KAction in konq_mainwindow.
Also fixed connect() warning in konq_undo when MKDIR.
CCMAIL: s.leiber@web.de, 66262-done@bugs.kde.org

Refer to Bug 66262 - konqueror creates directory in wrong directory
Diffs: 1, 2, 3, 4

Helge Deller committed a change to kdebase/kcontrol/usbview

apply fix for "kcmusb does not display any USB information with linux kernel-2.6.x." to HEAD too
Thanks to toshihiro for bug report & patch.
CCMAIL: 63660-done@bugs.kde.org

Refer to Bug 63660 - kcmusb does not display info with kernel-2.6
Diff

Helge Deller committed a change to KDE_3_1_BRANCH: kdebase/kcontrol/usbview

fix: "kcmusb does not display any USB information with linux kernel-2.6.x."
Thanks to toshihiro for bug report & patch.
CCMAIL: 63660-done@bugs.kde.org

Refer to Bug 63660 - kcmusb does not display info with kernel-2.6
Diff

Eric Coquelle committed a change to kdebase/kfind

Fixed bug #65992: Under Konqueror, KFind might show, once the search was achieved, any new created file.

Refer to Bug 65992 - Recently modified files are added to find result list.
Diffs: 1, 2, 3

Eric Coquelle committed a change to kdebase/kfind

Fixed bug 64955: important feature missing: search within all images, video & sounds

Refer to Bug 64955 - Search for all images, videos, etc.
Diffs: 1, 2, 3, 4

Luboš Luňák committed a change to kdebase/khotkeys

Use KShortcut consistently everywhere, so that multi-key shortcuts
work as well.
CCMAIL: 66871-done@bugs.kde.org

Refer to Bug 66871 - khotkeys does not accept multi-key shortcuts
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9

Luboš Luňák committed a change to kdebase/khotkeys/shared

This should fix #66663.

Refer to Bug 66663 - Crash on startup or apply config changes
Diff

Tobias Koenig committed a change to kdelibs/kio/kfile

Show hidden directories in directory chooser dialog.
That fixes #64106
CCMAIL:64106-done@bugs.kde.org

Refer to Bug 64106 - directory chooser dialog does not let me choose hidden directory
Diff

Waldo Bastian committed a change to kdelibs/kio/kio

Handle redirection from http://host to http://host/ for post jobs in
TransferJob instead of the slave because slave-based redirection changes
the post into a get. (BR64992)
CCMAIL: 64992-done@bugs.kde.org

Refer to Bug 64992 - form method="post" ignored when action URL has no path
Diffs: 1, 2

Kde-Pim

Features

Bo Thorsen committed a change to kdepim/kdgantt

Kroupware_branch merge. This method is needed.

CCMAIL: lutz@klaralvdalens-datakonsult.se

Diffs: 1, 2

Bo Thorsen committed a change to kdepim/kmail

Move dIMAP to a new folder manager. One bug is still there: It doesn't show up in the folder tree!

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20

Bo Thorsen committed a change to kdepim/korganizer

Finally! Here is the groupware patch. It's still not activated unless you know how, but at least the code is in. And that means korganizer compiles again.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
Bugfixes

Daniel Molkentin committed a change to kdeaddons/kontact/plugins/newsticker

fix header icons from newssources that like to set really huge icons
disrupting the newsticker layout.

finally fixes 65975.

CCMAIL:65975-done@bugs.kde.org

Refer to Bug 65975 - Alignment of RSS Feed titles in Kontact Newsticker is strange
Diffs: 1, 2

Stephan Kulow committed a change to kdepim

trying to get setenv work too
CCMAIL: 66620-close@bugs.kde.org

Refer to Bug 66620 - kdepim/libkdenetwork/kpgpbase.cpp fails to compile on Solaris
Diffs: 1, 2

Reinhold Kainhofer committed a change to kdepim

Implement deleting a journal entry (e.g. when you delete all the text from the journal view).

CCMAIL: 57319-done@bugs.kde.org

Refer to Bug 57319 - journal text is not updated if deleted
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9

Tobias Koenig committed a change to kdepim/kaddressbook

Update details page as soon as 'Ok' or 'Apply' is clicked in the contact editor.
That fixes #66574
CCMAIL:66574-done@bugs.kde.org

Refer to Bug 66574 - OK, Apply in contact edit dialog doesn't applies instantly
Diff

Tobias Koenig committed a change to kdepim/kaddressbook

Since we have the new locking mechanism where every contact which is
changed is stored back immediately, we don't need this annoying 'Do you want to save your changes' dialog anymore.
That makes bug report #65141 obsolete.
CCMAIL:65141-done@bugs.kde.org

Refer to Bug 65141 - Confirmation when closing with changes in addresses has ambiguous "Do not ask again" checkbox
Diffs: 1, 2

Till Adam committed a change to kdepim/kmail

Fix several reported and unreported selection breakages in the headers
list by relying on KListView to handle things instead of (brokenly) re-
implementing extended selection behavior ourselves.

CCMAIL: 55555-done@bugs.kde.org
CCMAIL: 55892-done@bugs.kde.org

Refer to Bug 55555 - Selecting a message with keyboard and mouse does not show selected message
Refer to Bug 55892 - mouse selection code badly broken
Diffs: 1, 2

Ingo Klöcker committed a change to kdepim/kmail

Fix bug 66589: Href style links get confused by KMail

Refer to Bug 66589 - Href style links get confused by KMail
Diffs: 1, 2

Till Adam committed a change to kdepim/kmail

o Move Properties to the end of the foldertree RMB menu.
o Add ... to Subscriptin menu item

CCMAIL: 66587@bugs.kde.org

Refer to Bug 66587 - usability: various styleguide problems
Diff

Daniel Molkentin committed a change to kdepim/kmail

To-be-improved patch to fix 66580. I owe a cookie to whoever finds out
why the sleep(2) is needed.

CCMAIL:66580-done@bugs.kde.org

Refer to Bug 66580 - RMB menu in kmreaderwin on address - Open in Addressbook doesn't work
Diff

Till Adam committed a change to kdepim/kmail

Let the account manager emit a signal when an account is removed so the
foldertree can select the local folders to avoid crashes when a folder
and a mail from the removed account is currently selected and being
displayed.

Should be improved eventually to only do it if the current account is
the removed one, but I didn't see an immediate way to do that.

CCMAIL: 66875-done@bugs.kde.org

Refer to Bug 66875 - Kmail crashed when removing imap mailbox
Diffs: 1, 2, 3, 4

Marc Mutz committed a change to kdepim/kmail

Properly escape ^From_ in mbox.

CCMAIL: 66373-done@bugs.kde.org, kmail@kde.org

The old code did s/\n>From/\nFrom/g (and vice versa). Correct would be
    s/(\n|^)(>*)>From /\1\2From /g.
This is what this change implements, excpet that it ignores From or >From
that start the string (just as the old code did). That's probably necessary
for now, since messages from mbox folders still contain the From spearator
line in msg->asString()...

Problem now is old mbox'es: KMail buggyly left ^>From_ alone in escaping
(leading to #66373) and ignored ^>>From_ in unescaping. The latter isn't
much of a problem, but the fact that ^FromFrom was also escaped, is. We
won't unescape that one anymore. But that's life, I guess.

Refer to Bug 66373 - '>From' is turned into 'From' when sending emails
Diffs: 1, 2

Ingo Klöcker committed a change to kdepim/kmail

Fix problems with replacing misspelled words. Based on patch by Daniel Naber.
CCMAIL: 66172-fixed@bugs.kde.org
CCMAIL: 66174-fixed@bugs.kde.org

Refer to Bug 66172 - spell suggestion replaces wrong word
Refer to Bug 66174 - using spell checking suggestion blocks undo
Diff

Tuukka Pasanen committed a change to kdepim/konsolekalendar

this is bed to fix the #65318 bug. it makes this application unusable;)

Refer to Bug 65318 - konsolekalendar can't access KOrganizer default calendar
Diffs: 1, 2, 3, 4

Reinhold Kainhofer committed a change to kdepim/korganizer

Put the two options for the Marcus-Bains-line together (into the view tab) and rename
the first one from "Show Marcus Bains line" to "Show current time (Marcus Bains line)"
so everybody will understand what that option means.

CCMAIL: 62647-done@bugs.kde.org

Refer to Bug 62647 - usability marcus bains line configuration
Diffs: 1, 2

Reinhold Kainhofer committed a change to kdepim/korganizer

Deleting an event with concurring events no longer crashes of you delete another
one of the conflicting items (in placeSubCells the currently placed cell wasn't
added as a conflicting item to the previously placed items, so when deleting one
of the previous items, it couldn't update the items placed later. Thus they still
had the delete event in their list of conflicting items -> crash when accessing it).
However, the problem is that when editing/deleting an event there is no easy way
to update the maxSubCells variable of its conflicting items. So I commented out
that optimized code and just call updateView() whenever an event is edited/deleted
(adding works fine with the optimized version).

Also found that stupid rounding bug that was responsible for #66539...

CCMAIL: 66539-done@bugs.kde.org, 64986-done@bugs.kde.org

Refer to Bug 66539 - Event doesn't always fill width of column for day, white space when side by side
Refer to Bug 64986 - multiple birthdays birthdayplugin plugin
Diffs: 1, 2

Reinhold Kainhofer committed a change to kdepim/korganizer

In Month view it doesn't make sense to go one day forward. Force KOrganizer to
always go exactly one week forward/backward.

CCMAIL: 62829-done@bugs.kde.org

Refer to Bug 62829 - Forward/back in month view inconsistent
Diffs: 1, 2, 3

Reinhold Kainhofer committed a change to kdepim/korganizer

Don't crash if the monthly recurrence doesn't have a day set (happens due to broken vcal
importer, will fix that one later. But crashing should never happen).

CCMAIL: 57252@bugs.kde.org

Refer to Bug 57252 - ical import filter - annually repeating items not imported
Diff

Reinhold Kainhofer committed a change to kdepim/libical/src/libical

NetBSD has to be treated similar to FreeBSD. Applied Mark Davies' patch for
bug 61798 (He says this patch fixes the NetBSD time zone problem. I don't have a machine
to test...).

CCMAIL: 61798-done@bugs.kde.org

Refer to Bug 61798 - korganiser display wrong time on NetBSD
Diff

Reinhold Kainhofer committed a change to kdepim/libkcal

Before using addMonthlyDay we need to set the recurrence type to monthly, otherwise
addMonthlyDay will immediately return without doing anything, and the recurrence will
have an empty set of days (and thus korganizer crashed when trying to access the first
of them). Use some default values, because we don't know the duration yet, which is
the last entry in the vcal RRULE. At the end, setMonthly will be called again with
the correct values, anyway.

With this fix, the .calendar file from bug 57252 can be correctlly imported (the ical
importer converts the .calendar file to a temporary .vcs file and loads that one).

CCMAIL: 57252-done@bugs.kde.org

Refer to Bug 57252 - ical import filter - annually repeating items not imported
Diff

Reinhold Kainhofer committed a change to kdepim/libkcal

Correctly import and export the location field in vcs files.

CCMAIL: 59152-done@bugs.kde.org

Refer to Bug 59152 - LOCATION not read/imported from vcs file
Diff

Till Adam committed a change to kdepim/libkdenetwork

Don't crash if the user starts typing in the filter line edit before there
are any folders loaded from the server.

CCMAIL: 66585-done@bugs.kde.org

Refer to Bug 66585 - Crash while subscribing to folders on imap server
Diff

Stephan Kulow committed a change to kdepim/libkdenetwork

I think, I found the reason for "FATAL: q codec lies about it's maxDecodedSizeFor"
- well, the q coded lied about it's maxDecodedSizeFor.
It took a diploma to figure that factories - but I managed to :)
CCMAIL: 65615-done@bugs.kde.org
CCMAIL: mutz@kde.org

Marc: I think, the real bug (and the fact it happened that often on ppc) was
in kmime_util.cpp, where one too many assumption about the signedness of char
happens ;(

Refer to Bug 65615 - kmail crashes with message: kmail: FATAL: q codec lies about it's maxDecodedSizeFor()
Diffs: 1, 2

Tobias Koenig committed a change to kdepim/libkdepim

Removed the line between the note and the rest of the contact.
It looked ugly and the layouting code in QTextEdit didn't allowed to fix
bug #66567 otherwise.
CCMAIL:66567-done@bugs.kde.org

Refer to Bug 66567 - With Details in Contact preview is moved right
Diff

Koffice

Bugfixes

Nicolas Goutte committed a change to koffice/lib/kofficecore

HACK: give back a mimimum of functionality to the save dialog when compiled
under KDE 3.1.x. (For KDE 3.2.x nothing is touched.)

This disables the saving to KOffice 1.1 format and to directories.
(The entries are now labeled "Empty file". Do *not* use them!)
However this permits now people to continue tracking bugs while using
KOffice CVS HEAD on KDE 3.1.x.

I repeat: this is a *hack*.

I am sorry for the inconveniences.
CCMAIL:66142@bugs.kde.org

Refer to Bug 66142 - KWord: crash when saving (destroying file dialog)
Diff

Nicolas Goutte committed a change to www/areas/koffice/developer

Explain the new work-around for bug#66142

Refer to Bug 66142 - KWord: crash when saving (destroying file dialog)
Diff

Konqueror

Features

David Faure committed a change to kdelibs/khtml

Allow implementation.createDocument("","",null);
loadxml.html now works fine.
CCMAIL: 61650-done@bugs.kde.org

Refer to Bug 61650 - khtml failing khtmltests/xml/loadxml.html testcase [testcase]
Diffs: 1, 2, 3, 4

David Faure committed a change to kdelibs/khtml

Patch from Darin Adler to implement Node.item (DOM-level-0, found in Moz & IE).

Diffs: 1, 2, 3

Dirk Mueller committed a change to kdelibs/khtml/rendering

allow enter to close the completion popup

Diff
Bugfixes

Dawit Alemayehu committed a change to kdebase/kcontrol/ebrowsing/plugins/shorturi

- Revert Waldo's commit (rev. 1.71) and fix it in a more configurable way.
  Email address matching is now specified in a config file and can easily
  be removed if people do not want it. The changes needed to make
  this possible also fixes a very old bug BR# 17789.

- Make the IPv4 regular expression much more tolerant. Should work for
  127.1 for example.

CCMAIL:17789-done@bugs.kde.org

Refer to Bug 17789 - character classes in regular expressions in kshorturifilterrc don't work
Diffs: 1, 2

David Faure committed a change to kdebase/konqueror

Better fix for 39214 - "Use index.html" not disabled when embedding e.g. kate:
It should still be enabled when actually viewing an index.html file using that feature.
CCMAIL: 66861-done@bugs.kde.org

Refer to Bug 39214 - Menu items not disabled when embedding kate
Refer to Bug 66861 - can't remove view -> use index.html check 
Diff

Stephan Kulow committed a change to kdelibs/khtml

neither Dirk nor Lars really objected against having this bug fixed, so I'm
commiting it as I consider konqueror changing user data a grave bug
CCMAIL: 62076-done@bugs.kde.org

Refer to Bug 62076 - Textarea elements improperly remove last newline on content display
Diffs: 1, 2

Lars Knoll committed a change to kdelibs/khtml

This should hopefully fix most of the repaint problems.

Problem was that Safari converted a method that took a bool
into taking a RenderObject *. No renderObject means full
repaing in Safari, while it converted to repaint=false
for us.

Diffs: 1, 2, 3, 4, 5, 6

Stephan Kulow committed a change to kdelibs/khtml

fixing rendering of disabled select options
CCMAIL: 61347-done@bugs.kde.org

Refer to Bug 61347 - disabled property not honored for option tag (testcase)
Diffs: 1, 2

Dirk Mueller committed a change to kdelibs/khtml

       * rendering/render_form.h (class RenderFileButton): use KURLRequester
       instead of just doing the stuff on our own in a worse way (#62328).
       Also provides completion, yay! :)

       right now <input type=file> has severe rendering errors which I blame
       on the widget painting code from Lars.

Refer to Bug 62328 - use file-chooser icon instead of text for file upload button
Diffs: 1, 2, 3

David Faure committed a change to kdelibs/khtml

Generate keypress, keydown and keyup events for the document if no node has the focus.
Factorized code in a new method, dispatchKeyEvent.
Cleaned up old unused variables d->lastKeyNode and d->lastKeyPress.
CCMAIL: 42918-done@bugs.kde.org, 43072-done@bugs.kde.org

Refer to Bug 42918 - document.onkeypress does not work
Refer to Bug 43072 - Google keys doesn't work (http://labs.google.com)
Diffs: 1, 2, 3

David Faure committed a change to kdelibs/khtml

Fixed 54929, anchor properties.
Fixed innerText misbehavior (it would scan the entire document!) on empty elements.

Refer to Bug 54929 - document.links incorrect for local anchor references
Diffs: 1, 2, 3

David Faure committed a change to kdelibs/khtml

* ecma/kjs_window.cpp (goURL): Compare the URLs without the ref, fixes
wrong reload when opening a tree-like structure (#54358).
CCMAIL: 54358-done@bugs.kde.org

Refer to Bug 54358 - Konqueror does not handle listing
Diffs: 1, 2

Stephan Kulow committed a change to kdelibs/khtml

reset the default stylesheet on config changes
CCMAIL: 20381-close@bugs.kde.org

Refer to Bug 20381 - 'Underline links' requires restart
Diffs: 1, 2

Stephan Kulow committed a change to kdelibs/khtml/rendering

make it compile - even though I have a bad feeling about use of alloca
CCMAIL: 66619-close@bugs.kde.org

Refer to Bug 66619 - kdelibs/khtml/rendering/font.cpp fails to compile on Solaris
Diff

Waldo Bastian committed a change to kdelibs/kioslave/http

Always set charset metadata. (BR65776)

Refer to Bug 65776 - khtml sometimes doesn't detect charset
Diff

David Faure committed a change to kdelibs/kjs

Fixed crash on http://www.ragingcow.com/ due to recent FuncExprNode change.

Diffs: 1, 2, 3

Multimedia

Features

Sebastian Trueg committed a change to kdeextragear-1/k3b/src

added a Thememanager and a new crystal theme created by everaldo.
ALthough it's just a gimmick one may now change all k3b graphics with
the thememanager. :)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20,
21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40,
41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60,
61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80,
81, 82, 83, 84, 85, 86

Sebastian Trueg committed a change to kdeextragear-1/k3b/src

reactivated the suidroot systemchecks for cdrecord, cdrdao, and readcd as many
user problems could be solved by configuring these programs suidroot nonetheless
what SuSE thinks. ;)
made the crystal theme the new default.

Diffs: 1, 2, 3, 4

Sebastian Trueg committed a change to kdeextragear-1/k3b/src

improved K3bIso9660 to support multisession and mixed mode CDs

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9

Stefan Gehn committed a change to kdemultimedia/noatun/modules/excellent

Fullfil wishlist Bug #66654 by using my own loop NoatunStdAction that both
shows the current loop-mode as well as offering all modes in a popupmenu. Also fixed
use of deprecated KAction::accel()

Refer to Bug 66654 - playlist looping action usage is not obvious
Diffs: 1, 2

Dirk Ziegelmeier committed a change to kdenonbeta/kwintv3

CCMAIL: kwintv@mail.kde.org
First shot of a channel wizard.
Switch to XAWTV channel lists for importing default channels.
Frequency scanning needs much polishing.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20,
21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40,
41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55
Optimizations

Maks Orlovich committed a change to kdemultimedia/juk

Reduce memory usage by roughly a 1/3rd, by:
1. Reove a redudndant copy of the file path in CachedTag
2. Try to get multiple copies of the same text to use the same
underlying data object more often.
3. Don't let QString get too pre-allocation happy.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10
Bugfixes

Tobias Koenig committed a change to kdelibs/arts/knotify

The crash is in KConfigGroup, which got a null pointer as first argument...
this was caused by a not existing config file for 'appName'.
It should be fixed now.
CCMAIL:65809-done@bugs.kde.org

Refer to Bug 65809 - knotify client crashes when kopete/gadu is trying to display notification
Diff

Scott Wheeler committed a change to kdemultimedia/juk

Default to playing the first matched item rather than the first item in the
list if there is no selection and the user presses play.

CCMAIL:65872-done@bugs.kde.org

Refer to Bug 65872 - Pressing Play keyboard shortcut plays first time from collection list, not of search
Diff

Stefan Gehn committed a change to kdemultimedia/noatun/library

Fix bug #66345, first load all plugins except playlists and at the end unload
the old + load the new one.

Refer to Bug 66345 - switching from one interface plugin to another crashes noatun!
Diffs: 1, 2

Networking Tools

Features

Casey Allen Shobe committed a change to kdenetwork/kopete/styles

CCMAIL:66568-done@bugs.kde.org
Implemented as described.

Refer to Bug 66568 - Put both forms of identification to Kopete.xsl contactDisplayName tooltip.
Diff

Frerich Raabe committed a change to kdenetwork/librss

- Fundamental support for RSS 1.0 so that the tagesschau.de feed gets recognized
- Work around weird change in QDomElement's behaviour

Diffs: 1, 2
Bugfixes

Petter E. Stokke committed a change to kdeextragear-2/kmldonkey/scripts

kmldonkey_submit now uses the mldonkey console to submit URLs, which lets it
ensure all URLs are submitted successfully, and display error dialogs for
failures.

CCMAIL: 62923-done@bugs.kde.org

Refer to Bug 62923 - add all ed2k links in page partially broken
Diffs: 1, 2

Jason Keirstead committed a change to kdenetwork/kopete

Fix bug #333 relating to away while op / voice. Requires disconnection
of status update signal when setContactOnlineStatus is called in KMM. This
is only relavent to IRC right now, but this should be proper behaviour
for any protocol that used this function.

Also remove extrenuous signal in KMM.

CCMAIL: 66776-done@bugs.kde.org

Refer to Bug 66776 - Away overrides OP and VOICE statuses
Diffs: 1, 2, 3, 4, 5, 6, 7

Matt Rogers committed a change to kdenetwork/kopete/kopete

Fix Bug 61569 by only enabling the Connect All and Disconnect All after we've
loaded at least one account.  This may not catch all the corner cases, but
it keeps the Connect All and Disconnect All buttons from doing anything if
a user skips the setup on first launch. (Account loading is pretty fast anyways)

CCMAIL: 61569-done@bugs.kde.org

Refer to Bug 61569 - "Connect All" needs to wait for plugins to be loaded
Diff

Matt Rogers committed a change to kdenetwork/kopete/kopete

commit the part of the fix for bug 61569 that waits for all the plugins to be
loaded first before enabling the Connection actions

Refer to Bug 61569 - "Connect All" needs to wait for plugins to be loaded
Diffs: 1, 2

Richard Lärkäng committed a change to kdenetwork/kopete/kopete/chatwindow

Check editpart->simple() instead of just editpart when determining
if it's plaintext or not.

Fixes 66612 for protocols which doesn't support rich text,
but not sure how to do it for those that do, I'll leave that for
someone who knows this better

CCMAIL: 66612@bugs.kde.org

Refer to Bug 66612 - Send message button disabled if message consists only of <foo>
Diff

Jason Keirstead committed a change to kdenetwork/kopete/kopete/chatwindow

Add a 2px margin around the whole area ( not marginHint() == 4px cause this looks horrible ),
and a 4px indent to the status text, cause it needs more breathing room than the button.

CCMAIL:66085-done@bugs.kde.org

Refer to Bug 66085 - Status message in chat window has no margin
Diff

Jason Keirstead committed a change to kdenetwork/kopete/plugins/cryptography

Check if a message matches the RTF profile before escaping it

CCMAIL:63983-done@bugs.kde.org

Refer to Bug 63983 - Does not handle HTML tags in decrypted messages
Diffs: 1, 2

Jason Keirstead committed a change to kdenetwork/kopete/protocols/irc

Issue ISON on connect so we see online users right away

CCMAIL:66244-done@bugs.kde.org

Refer to Bug 66244 - IRC plugin does not perform ISON immediately after connect.
Diffs: 1, 2

Will Stephenson committed a change to kdenetwork/kopete/protocols/irc

Correct the colouring of channel and server icons.

The reason for this was that the base icon and the icon used for the status overlay
were one and the same.  After colourising the base, the overlay is drawn onto it.
If they are identical, any colourisation will be completely covered.

Note that it is never a good idea to take your overlay icons (specified in
KopeteOnlineStatus ctors) from the same set of images that comprise your base icons.
If you don't want an overlay, use QString::null for the 5th argument to the KOS ctor.

CCMAIL: 66224-done@bugs.kde.org

Refer to Bug 66224 - Channel and Server window icons do not follow account coloring
Diff

Jason Keirstead committed a change to kdenetwork/kopete/protocols/irc

Fix nick change bug

CCMAIL: 65979-done@bugs.kde.org

Refer to Bug 65979 - Sometimes duplicate self-entries are shown on IRC channels
Diffs: 1, 2

Jason Keirstead committed a change to kdenetwork/kopete/protocols/irc/ui

Verify server and port exist using KExtSocket

CCMAIL:61052-done@bugs.kde.org

Refer to Bug 61052 - Adding non-existent server does not give any error
Diff

Richard Lärkäng committed a change to kdenetwork/kopete/protocols/sms

Fix BR: 66602 (kopete sms contact cant change phone number) by
deleting the current contact and creating a new one when changing
phone number

Also, remove Apply from User Preferences, as it would break with
this change

CCMAIL: 66602-done@bugs.kde.org

Refer to Bug 66602 - kopete sms contact cant change phone number
Diffs: 1, 2, 3

Matt Rogers committed a change to kdenetwork/kopete/protocols/yahoo

Fix bug 62574 by displaying messages in color if they have it
Fix bug 63302 by using the timestamp that yahoo sends when we get an offline
message

CCMAIL: 62574-done@bugs.kde.org
CCMAIL: 63302-done@bugs.kde.org

Refer to Bug 62574 - yahoo messages not received when colored
Refer to Bug 63302 - offline messages sent on yahoo protocol don't display correct time of sending
Diffs: 1, 2

Jason Keirstead committed a change to make_it_cool: kdenetwork/kopete/protocols/irc

1. Fix up this branch, seems to have gotten wrong files
2. Add IRC Charset selection per-contact / conversation

CCMAIl:57129-done@bugs.kde.org

Refer to Bug 57129 - Large fontsize and wrong special chars in messagewindow
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17

User Interface

Features

Waldo Bastian committed a change to kdebase/kicker

* Alt-F1 pops up KDE-menu above KDE-button
* Support for kde-menu --highlight

Diffs: 1, 2, 3, 4, 5, 6

Luboš Luňák committed a change to kdebase/kwin

Don't obscure windows that are not visible, otherwise switching between
two empty desktops can flicker.

Diff
Bugfixes

Sandro Giessl committed a change to kdeartwork/styles/plastik

CCMAIL: 66681-done@bugs.kde.org

Don't blindly rely on RTL info detected once at the construction.

Refer to Bug 66681 - Plastik style tab widgets have rendering errors when switching from LTR to RTL mode
Diffs: 1, 2

Stephan Binner committed a change to kdebase/kdesktop

Fixed "Bug 59488: kdesktop: icons disabled breaks mousewheel desktop switching"

Refer to Bug 59488 - kdesktop: icons disabled breaks mousewheel desktop switching
Diffs: 1, 2

Waldo Bastian committed a change to KDE_3_1_BRANCH: kdebase/kmenuedit

Don't connect copy/cut/paste multiple times when switching between
"show hidden". (BR66136)
CCMAIL:66136-done@bugs.kde.org

Refer to Bug 66136 - Copy/Paste can cause Duplicates
Diff

Daniel Molkentin committed a change to kdelibs/kdeui

- Doesn't crash anymore
- Won't look weired either

tradeoff: It's probably wrong ;)

Anyway I will commit this as this fixes #66431 and adds no obvious breakage.
Matthias, please review. Thanks to Lauri and Coolo for the investigation

CCMAIL:66431-done@kde.org

Refer to Bug 66431 - Kontact crashes when opening the Kontact settings dialog
Diff

Tobias Koenig committed a change to kdelibs/kdeui

Allow autocompletion when NumKey is on, otherwise you won't be able to work
with Keypad. That fixes #53840
CCMAIL:53840-done@bugs.kde.org

Refer to Bug 53840 - Completion does not work with NumPad Keys
Diff

Utilities

Bugfixes

Jeroen Wijnhout committed a change to branch_1_6: kdeextragear-2/kile/kile

fix Bug 66522: Projects cannot contain files not in subfolder of .kilepr file

Refer to Bug 66522 - Projects cannot contain files not in subfolder of .kilepr file
Diff

Petter E. Stokke committed a change to kdeextragear-2/kmldonkey/kmldonkey

Sort the availability column on the number of available sources. It's not
entirely accurate (would be better to actually evaluate the percentage of
available chunks), but efficiency is more important than accuracy in this
case.

CCMAIL: 66033-done@bugs.kde.org

Refer to Bug 66033 - Sorting by availability on download page incorrect
Diff

Christian Loose committed a change to kdetoys/kweather

BR #54858: Fix untranslated strings in weather report dialog.

CCMAIL: 54858-done@bugs.kde.org

Refer to Bug 54858 - (patch) Untranslatable strings in KWeather
Diff

Stanislav Kljuhhin committed a change to kdeutils/kjots

fix for bug 65710

Refer to Bug 65710 - Removing the last book leaves its description table on the right side
Diff

Stanislav Kljuhhin committed a change to kdeutils/kjots

fix for bug 66525

Refer to Bug 66525 - kjots does not save last line entered
Diff

Jesper Pedersen committed a change to kdeutils/kregexpeditor

fixed bug #66857 - error when using hexidecimal regeps

Refer to Bug 66857 - KRegExpEditor handles wrong some hexadecimal unicode values
Diffs: 1, 2, 3

Matt Rogers committed a change to kdeutils/ktimer

Give KTimer an icon. Currently it's just the xclock icon from kdebase.

CCMAIL: 40714-done@bugs.kde.org

Refer to Bug 40714 - View Image Info with Right Click in browser
Diffs: 1, 2, 3, 4, 5, 6

Daniel Molkentin committed a change to kdeutils/kwallet/konfigurator

Fix tab sorting order

CCMAIL:66691-done@bugs.kde.org

Refer to Bug 66691 - keyboard tab navigation in kcmwallet has confusing order
Diff


Thanks for reading KDE-CVS-Digest