Last Week Archives

KDE-CVS-Digest

Weekly View of KDE CVS commits

November 28, 2003

By Derek Kite



This Week:

Khtml regressions and font handling fixed. amaroK, another media player, now has a resume feature, and can play streams. Plus many bugfixes in all applications.


Web browser rendering engines are hard. As we've seen over the last couple of months, when new capabilities are added to the rendering engine, regressions happen. What worked before, doesn't anymore. This is where automatic testing can help. As you peruse the khtml commits for the week, you will see that many regressions are being fixed. Stephan Kulow explains how the khtml testing works:

The khtmltests/regression CVS directory contains 3 subdirs:
tests, baseline and output. Within tests there are several .html and .js
files that contain test cases. These test cases do not have much of a meaning
for themselves - they are there to be checked by khtml/test_regression.
So if you fixed a bug or implemented a new feature in khtml or kjs, 
do in khtml('s builddir):
make test_regression && ./test_regression $SRCDIR/khtmltests/regression

This will output a lot of debug output, so I'm usually adding a 
"2>/dev/null  | tee log" behind the command line. This only outputs
lines with PASS and FAIL. Currently we have 20 failing tests in there,
so don't worry too much if you changed something in khtml and 12 javasript
test cases fail :)

test_regression will check the dom and the renderer tree against what
is in baseline, so if you change a test case, it will happen, that 
test_regression will output FAIL for that test case (like after Koos's 
commit). In that case, it creates the new version in the output subdir.
So you can diff against the baseline yourself and see if everything is fine.
The commit above adds actually 3 failing tests, so this is no good regression 
test. The regression database is supposed to be all passes at all times 
(we'll sort out the currently failing ones soon - I may hope).

But in general we're in big lack of good and working test cases. Actually
everything that works fine with current CVS should be documented as
test case. So that when you fix something that does not work, you see
if you broke something that worked before.

So at least for everything that you fixed from now on, you should supply
a test case for - if it can be tested at all.
This brings me to what can be tested currently:

We can test .js just fine as the scripting language is build in. There is a
little shell.js that offers the function shouldBe, that can be used to check
assertions. Actually thanks to the mozilla test suite we've got some 1000
javascript test files that contain each tons of tests.

We can also test html parser in comparing resulting DOM tree. This can
also be used to test ecma manipulations. To check the DOM tree is of 
course a lot more fragile than testing assertions, so checks that break
with a fix in the HTML parser have to be double checked if the result
is still what is expected (you'll need IE for that ;-).

An even more fragile, but also very useful test is the check for the 
renderer tree. We can check through this if the renderer tree is similiar
to what it was before. As test_regression sets the environment very
strictly in using everywhere the same screen resolution, window size,
widget style, fonts, etc. this is something that can be used to test against
several breakages. Of course we can't test with this the actual painting
and we can't really test behavior in selection, mouse hovering, etc.

To check the painting, I'm already having plans to actually compare images,
that must be fun and for the other stuff we might add special hooks, so this
is just the beginning. My hope is that many more can write good test cases
than those that can actually fix bugs. But fixing bugs (and merging other's
code in :) is much easier if you've got a collection of test cases that show
when something's broken. 

And as soon as this test suite stabilizes and is failure free, I'm planning to
run it per cron job, so that you get fresh feedback.

I usually don't announce applications outside of the kde repository, but here is an exception. Guillaume Laurent announced a new release of Rosegarden:

The Rosegarden team are pleased to announce the release of
Rosegarden-4 0.9.5, an audio and MIDI sequencer and score editor
for Linux.  To download the source package, go to the homepage at

  http://www.all-day-breakfast.com/rosegarden/

This release contains a host of new features and improvements
over the previous release, and is nearly feature complete for 1.0.

Features include:

 o Score, piano-roll, event list and track overview editors
 o MIDI and audio playback and recording using JACK
 o Audio plugin support using LADSPA
 o Score interpretation of performance MIDI data
 o MIDI file I/O, Csound and Lilypond export
 o Shareable device (.rgd) files to ease MIDI portability
 o Translations into Russian, Spanish, German, French and Welsh

New features since 0.9.1 include:

 o Better sequencer comms layer for much more robust MIDI sequencing
 o Control rulers for editing velocity and control events
 o Controller management for MIDI devices
 o Event list editor with some actual editing capabilities
 o Event filter on current selection
 o Classification of audio plugins using liblrdf
 o Percussion and variations support in bank management
 o Import Studio from File
 o Markers
 o File merging for all file types
 o Notation rendering using real scalable fonts (one supplied)
 o Multi-page notation rendering with panner
 o Much better score printing
 o Print Preview
 o Segment colouring
 o Configurable metronome
 o Better Lilypond export
 o MusicXML export that works, though it's still pretty basic
 o Can now drag notes around in notation view
 o Several new .rgd device files
 o Better handling of MIDI devices that come and go
 o Much improved audio scheduling infrastructure
 o Ability to drag-and-drop audio files onto segment canvas
 o Many optimisations throughout

One year ago, the 3.1 release was packaged up and ... Kopete got a Yahoo plugin, work proceeded on Proklam, part of the kdeaccessibility project.

Statistics

Commits:1847 by 190 developers, 350024 lines modified, 1054 new files
Open bugs:4535
Open wishes:4922
Bugs opened:380 in the last 7 days
Bugs closed:427 in the last 7 days

CVS Commit Summary
ModuleCommits
kde-i18n 700
kdenonbeta 210
kdelibs 145
kdebase 87
khtmltests 81
kdepim 75
kdeextragear-2 69
quanta 66
koffice 47
kdegraphics 42
CommitsDeveloperLines
86 Stephan Kulow 9085
76 Gregory Mokhin 7971
75 Pedro Morais 4695
71 Laurent Montel 685
49 Erik K. Pedersen 10348
46 David Faure 401
41 Thomas Diehl 1509
40 Andras Mantia 1836
37 Unai Garro 1416
34 Marcos Goienetxe 116402
Internationalization Status
Swedish (sv)  100.00%
British English (en_GB)  99.92%
Danish (da)  99.69%
Portuguese (pt)  98.61%
Brazilian Portuguese (pt_BR)  97.13%
Spanish (es)  96.08%
German (de)  95.78%
Estonian (et)  94.79%
Italian (it)  93.57%
Hungarian (hu)  92.16%

Table of Contents


Application Features Optimize Security Bug Fixes
Development Tools       fix
Games       fix
Graphics new     fix
Kde-Base       fix
Kde-Pim       fix
Koffice       fix
Konqueror new     fix
Multimedia new     fix
Networking Tools new   sec fix
User Interface       fix
Utilities       fix
Click on the icons to go to the respective section!

Development Tools

Bugfixes

Hamish Rodda committed a change to kdelibs/kate/part

Fix detection of clipboard contents.

Reviewed by Christoph Cullmann <cullmann@kde.org>

CCMAIL: 68772-done@bugs.kde.org

Refer to Bug 68772 - first paste from outside X app doesn't work
Diff

Hamish Rodda committed a change to kdelibs/kate/part

Fix selection weirdness when switching between selection modes with a valid
current selection.

Reviewed by Christoph Cullmann <cullmann@babylon2k.de> and 
            Jesse Yurkovich <yurkjes@iit.edu>

CCMAIL: 67615-done@bugs.kde.org

Refer to Bug 67615 - switching from line selection to block selection, redraw error
Diffs: 1, 2

Hamish Rodda committed a change to kdelibs/kate/part

Fix undo functionality with code completion active.

Reviewed by Christoph Cullmann <cullmann@babylon2k.de>

CCMAIL: 55276-done@bugs.kde.org

Refer to Bug 55276 - autocompletion part has strange behavior
Diff

Jesse Yurkovich committed a change to kdelibs/kate/part

fix for 69021

Refer to Bug 69021 - kate crashes when i copy the contents of one php file into a new file and start editing it.
Diffs: 1, 2

Christoph Cullmann committed a change to kdelibs/kate/part

fix for bug #68144: unable to copy/cut via context menu after folding some lines 
before the selection

Refer to Bug 68144 - folded code makes rightclick for context menu deselect selected text
Diff

Christian Loose committed a change to kdesdk/cervisia

Fix BR #69086:
Conversion from directory command-line argument to an URL fixed.

Reviewed by Waldo.

CCMAIL: 69086-done@bugs.kde.org

Refer to Bug 69086 - "cervisia ." doesn't work anymore
Diff

Otto Bruggeman committed a change to kdesdk/kompare

* Remove the Show entire file option. It only causes problems at the moment
CCMAIL: 68729-done@bugs.kde.org

Refer to Bug 68729 - Does not honor the "Show entire file when comparing" flag
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9

Otto Bruggeman committed a change to kdesdk/kompare

* Fix Help->Report bug... dialog to the default report to bugs.kde.org instead 
of sending mail to John.

Keep them bugreports coming Amilcar :) I really appreciate it. Thanks again !

CCMAIL: 68730-done@kde.org

Refer to Bug 68730 - The "Help->Report bug" feature still uses the old e-mail system
Diffs: 1, 2

Otto Bruggeman committed a change to kdesdk/kompare

Fix bug 68872
CCMAIL: 68872-done@bugs.kde.org

Refer to Bug 68872 - The "Report bug..." feature adds an extra v character
Diff

Otto Bruggeman committed a change to kdesdk/kompare

* Splitting up apply and unapply into 2 seperate actions to fix 68871 in a 
better way. This causes an menu key accel conflict but i'll fix that after 3.2. 
This does not introduce new strings.

Reviewed by Amilcar who is a happy user now :)

Refer to Bug 68871 - Please revert to the old apply button
Diffs: 1, 2, 3

Otto Bruggeman committed a change to kdesdk/kompare/libdiff2

* Rework the blendFile method so it actually works and as a bonus is a bit faster
This introduces a new form of show entire file when comparing, one that works :)
And because of it, it saves files properly now because the entire file is now available 
even if you have a single line change in a million line file with only 2 context lines 
in the diff.

Reviewed by Scott

CCMAIL: 68569-done@bugs.kde.org

Refer to Bug 68569 - Save only saves the part of the file that was modified
Diff

Otto Bruggeman committed a change to kdesdk/kompare/libdiff2

Fix bug 68871 and make sure it does not try to blend for now when we are showing a diff

CCMAIL: 68871-done@bugs.kde.org

Refer to Bug 68871 - Please revert to the old apply button
Diff

Stephan Kulow committed a change to kdesdk/scripts

fixing moving failed log files in combination with compression
CCMAIL: 68363-done@bugs.kde.org

Refer to Bug 68363 - kde-build script fails to recognise compressed name change when renaming file after fail
Diff

Oliver Kellogg committed a change to kdesdk/umbrello

Update the beast fix chart.
Brian, I left you a parking lot for 65502 ;-)

Refer to Bug 65502 - C++ code generator is broken, maybe other as well
Diff

Luis De la Parra Blum committed a change to kdesdk/umbrello/umbrello

Fix bugs 59774 and 68395.
See comments on bugs.kde.org

Refer to Bug 59774 - crash when cutting last diagram left
Refer to Bug 68395 - import of classes results in sig11 (with a little help)
Diffs: 1, 2, 3, 4, 5

Oliver Kellogg committed a change to kdesdk/umbrello/umbrello

Fix bug 68701 (crash after class import.)
Brian, could you take a look at UMLDoc::deleteContents, I had to
take out a change you made in there in revision 1.101.

Refer to Bug 68701 - crash when creating a new doc after class import
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9

Alexander Dymo committed a change to kdevelop/buildtools

Emit aboutToRemoveFromSourceInfo signal before doing the actual remove in the 
project manager. This allows the classview to delete properly assosiated symbols from 
class tree and combos.
CCMAIL: 67995-done@bugs.kde.org

Refer to Bug 67995 - class view doesn't update when removing/adding files
Diffs: 1, 2, 3, 4

Alexander Dymo committed a change to kdevelop/buildtools/qmake

Remove scope in qmake manager works now. Also fixed adding nested scopes.
CCMAIL: 67391-done@bugs.kde.org
CCMAIL: jsgaarde@tdcspace.dk

Refer to Bug 67391 - remove of scope fails
Diffs: 1, 2, 3, 4

Jens Dagerbo committed a change to kdevelop/languages/cpp

Avoid crashing when the parser has gotten confused. See bug #68726.

Refer to Bug 68726 - crash on cpp namespace text completion
Diff

Jens Dagerbo committed a change to kdevelop/languages/php

Avoid crashing when the passed KIO::Job is 0 
 
CCMAIL: 69047-done@bugs.kde.org 

Refer to Bug 69047 - kdevelop crash after selecting php invocation method
Diff

Jens Dagerbo committed a change to kdevelop/languages/php/app_templates/phphello

fixes the bug part of the #69008 bug report

Refer to Bug 69008 - A PHP 'Hello World' program that could produce XHTML instead of HTML 4.0
Diff

Jens Dagerbo committed a change to kdevelop/lib/cppparser

Take a copy of the structure while it is valid in order not to crash later. 
I don't know why the map entry gets invalidated, but Roberto says the 
patch works, so here goes...

CCMAIL: 68704-done@bugs.kde.org

Refer to Bug 68704 - crash when using temporary preprocessor macros (possibly related to code completion)
Diff

Alexander Dymo committed a change to kdevelop/parts/outputviews

Find next and find previous error will restart the search from the beginning / end 
of the messages list if the error can't be found.
CCMAIL: 68815-done@bugs.kde.org

Refer to Bug 68815 - Find next error and end of list
Diffs: 1, 2

Andras Mantia committed a change to quanta/quanta

Make the update opening/closing tag working also in case of <></>.

CCMAIL: 68938-done@bugs.kde.org

Refer to Bug 68938 - Update opening/close tag stops working when last char is deleted
Diffs: 1, 2

Nicolas Deschildre committed a change to quanta/quanta/parts/kafka

* Apply the possible bugfix 68386 to HEAD

Refer to Bug 68386 - quanta crashes on start
Diff

Andras Mantia committed a change to quanta_be: quanta/quanta

Handle cases like "<ul><li></ul>" correctly. 
CCMAIL: 68941-done@bugs.kde.org 

Refer to Bug 68941 - Problem reporter doesn't accept unclosed LI
Diffs: 1, 2

Andras Mantia committed a change to quanta_be: quanta/quanta

Always show the correct item in the context help. 
CCMAIL: 68939-done@bugs.kde.org 

Refer to Bug 68939 - context help sometimes shows wrong page
Diffs: 1, 2

Games

Bugfixes

Rob Kaper committed a change to kdegames/atlantik/libatlantikui

fix wish #68590, too trivial to ignore and kind of a usability issue anyway

Refer to Bug 68590 - wish: property colours in the trade dialog
Diff

Graphics

Features

Nikolas Zimmermann committed a change to kdegraphics/ksvg/dom

Slave work started in dom/*, the biggest bugfix ever & urgent

First idea by Fred Schättgen, reviewed by Rob & me.

* check if handle() is defined in the header, if not do it
* correct copy constructor/assignement operator, see ksvg-devel for details
* fix SVGTests, SVGLangSpace, SVGStylable, etc.. which can't use refcounting
  as SVGTestsImpl etc. don't inherit from DOM::DomShared, though they need
  a working copy ctor and assignment op :)

102 classes to go

printnodetest finally works!!!! :)
Commit part one

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 
21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 
41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 
61, 62, 63, 64, 65, 66

Clarence Dang committed a change to kdenonbeta/kolourpaint

Introducing "Autocrop", the feature that automagically trims away the
borders of any image.  Unlike the traditional "Crop" function found in
many paint programs, this requires _no_ effort on the part of the user.

No more eyestrain...

No more pointless zooming...

No more wasted time!

Diffs: 1, 2, 3, 4
Bugfixes

Stefan Kebekus committed a change to kdegraphics/kdvi

Fixes bug #68384

Refer to Bug 68384 - 1st page not displayed
Diff

Stefan Kebekus committed a change to kdegraphics/kdvi

fixes bug #68404

Refer to Bug 68404 - Kdvi appears not to handle footnote links properly
Diffs: 1, 2

Luís Pedro Coelho committed a change to kdegraphics/kghostview

We need to handle the case where !dsc()->isStructured() differently.
Since we can't tell how to divide the file, we pass it whole to gs and let it
figure it out. We lose page navigation, but this shows up mostly in one
page .eps and weird .ps so it doesn't matter that much.

Related bugs (not wholly fixed yet, other patches will follow): 
	67901, 61257 and probably 23970.

Reviewed by Waldo.

Refer to Bug 61257 - kghostview doesnt render this PS file
Refer to Bug 23970 - kghostview totally confused without %%Page:
Diff

Matthias Kretz committed a change to kdegraphics/kview/modules/presenter

one QObject::connect warning less:
If the parent() doesn't exist we either leave the "File Open" action
in an unusable state or KView was just shutting down and therefor we
can ignore this. I've only seen the second one happening and to get
rid of the QObject::connect warning we do the parent() check.

CCMAIL: 69107-close@bugs.kde.org

Refer to Bug 69107 - Connection to null object
Diff

Kde-Base

Bugfixes

Waldo Bastian committed a change to kdebase

Detect clashes between shortcuts. (BR46132)
46132-done@bugs.kde.org

Refer to Bug 46132 - Does not check for duplicate application shortcuts
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11

Oliver Bausinger committed a change to kdebase/kicker/core

kicker applet transparency fixes (#64707)

container_applet.*:
- introduce setBackground() functions for InternalAppletContainer
and ExternalAppletContainer that grab the ContainerArea's background
image and set it correctly for the applet

containerarea.*: 
- introduce updateAppletsBackground() as a convenience function 
whenever a repaint of the applets is necessary and
- populate ContainerArea with a bunch with necessary repainting calls

Refer to Bug 64707 - PATCH: kicker transparency problems / errors
Diffs: 1, 2, 3, 4

Oliver Bausinger committed a change to kdebase/kicker/proxy

kicker applet transparency fixes (#64707)

appletproxy: 
- introduce a new dcop function to set the background pixmap
of an applet
- renamed / altered setBgMode() to repaintApplet() as this 
better matches its new function

Refer to Bug 64707 - PATCH: kicker transparency problems / errors
Diffs: 1, 2

Waldo Bastian committed a change to kdebase/klipper

newInstance() needs to switch of the DCOP priority call mode otherwise
non-priority calls will never get handled. This is normally handled by
KUniqueApplication. (BR68134)
CCMAIL: 68134-done@bugs.kde.org

Refer to Bug 68134 - kpastetextaction + klipper hang
Diff

Luboš Luňák committed a change to kdebase/kpager

snprintf is supposed to be snprintf. This shows how bad it's to have local
config.h (I wonder I reporter of #67927 could hit this part of code).

Refer to Bug 67927 - compile error in windowdrag.cpp with suse 8.2
Diff

Waldo Bastian committed a change to kdelibs/dcop/KDE-ICE

Don't crash on bogus iceauth file (BR68809)

Refer to Bug 68809 - kdeinit/ksplash/ksmserver crash on startup if iceauth fails
Diff

Waldo Bastian committed a change to kdelibs/kdecore

* Fix translation of "can't write" error message.
* Encode [ and ] in group names with [[ and ]], please review. (BR67731)
CCMAIL: 67731-done@bugs.kde.org

Refer to Bug 67731 - Naming dekstop icons with certain characters causes the system to not be able to save position of icon
Diff

Lauri Watts committed a change to kdelibs/kdoctools/customization

Removing broken XSL template to fix #68972

Refer to Bug 68972 - meinproc does not output <programlisting> content in html
Diff

George Staikos committed a change to kdelibs/kio/misc/kwalletd

Display 'KDE' when appid is empty.  This is temporary until string freeze
ends.

CCMAIL: 67758-done@bugs.kde.org

Refer to Bug 67758 - Incorrect message accessing kdewallet
Diff

George Staikos committed a change to kdelibs/kio/misc/kwalletd

rudimentary implementation of dcop transactions for kwallet.  still leaves
much to be desired, but it seems to help with the deadlock issue anyways.

CCMAIL: 65978-done@bugs.kde.org

Refer to Bug 65978 - KWallet-related deadlock involving mouse grabs
Diffs: 1, 2

David Faure committed a change to kdelibs/kioslave/ftp

Fixed listing of e.g. ftp.trolltech.com
list -a apparently disables -l -> so we need -la.
I hate FTP.
CCMAIL: 68913-fixed@bugs.kde.org

Refer to Bug 68913 - cannot get file list for ftp.trolltech.com
Diff

George Staikos committed a change to kdelibs/kwallet/backend

fix solaris build

CCMAIL: 69141-done@bugs.kde.org

Refer to Bug 69141 - kdelibs/kwallet/backend/blowfish.cc doesn't compile on Solaris
Diff

Kde-Pim

Bugfixes

Tobias Koenig committed a change to kdeaddons/kontact/plugins/newsticker

Update the view when configuration has changed.

CCMAIL:67012-done@bugs.kde.org

Refer to Bug 67012 - news ticker doent respect configured article count
Diffs: 1, 2

Tobias Koenig committed a change to kdepim/kaddressbook/kcmconfigs

Make it work with current KCModul again.
That should fix #68505 as well, since the password wasn't written to
config file when closing the dialog without this patch.

CCMAIL:68505-done@bugs.kde.org

Refer to Bug 68505 - KAddressbook submits password to LDAP server as character #37 instead of the password
Diffs: 1, 2

David Jarvie committed a change to kdepim/kalarm

Bug 68630: don't disallow expired start times for recurring alarms.
Fix error displaying time of expired repeat-at-login alarms.
Prevent attempted entry of recurrence end date earlier than start date or today.

Refer to Bug 68630 - recurring alarms starting in the past should be acceptable
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9

David Jarvie committed a change to kdepim/kalarm

Bug 68630: prevent immediate output of alarm with start time before now

Refer to Bug 68630 - recurring alarms starting in the past should be acceptable
Diff

Ingo Klöcker committed a change to kdepim/kmail

Fix crash on Solaris in case aMsg->fromEmail() is empty. Writing an empty string 
would anyway not be correct so we write a dummy string now in case it's empty. Based 
on patch by Torsten Kasch.
>
> CCMAIL:68801-fixed@bugs.kde.org

Refer to Bug 68801 - kmail crashes in KMFolderMbox::addMsg() due to NULL pointer in fprintf() args
Diffs: 1, 2

Till Adam committed a change to kdepim/kmail

Don't ask the kernel for the mainwidget to ask the mainwidget for the 
active readerwindow to ask that for the attachmentstrategy but pass it
along with the folder job, so it is available when the mime structure
comes in with load on demand. Remove unused KMKernel::activeReaderWindow
which doesn't work in kontact anyhow.

CCMAIL: 67644-done@bugs.kde.org

Refer to Bug 67644 - Preview contents dissappear after viewing IMAP emails
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19

Till Adam committed a change to kdepim/kmail

Make sure a lonely message arriving in a folder gets loaded into the reader
window.

CCMAIL: 68410-done@bugs.kde.org

Refer to Bug 68410 - new email not displayed in preview pane when inbox is empty and email is barely received
Diff

Tobias Koenig committed a change to kdepim/kmail

Removed the 'iterate over all toplevel windows and call readConfig()' hack
by a clean signal/slot solution to notify the single components of a change
in the config dialog.
That fixes also #67484.

CCMAIL:67484-done@bugs.kde.org

Refer to Bug 67484 - config changes in Kontact are not applied immediately to the KMail component
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12

Tobias Koenig committed a change to kdepim/kmail

Use only one 'Configure Shortcuts...' action when embedded in Kontact.
That fixes #67935.

CCMAIL:67935-done@bugs.kde.org

Refer to Bug 67935 - Kontact "Settings" menu has duplicate "Configure shortcut..." items
Diffs: 1, 2, 3

Ingo Klöcker committed a change to kdepim/kmail

Fix bug 64251: resizing mail preview garbles MIME-Tree display

Patch by Jeffrey McGee

CCMAIL:64251-fixed@bugs.kde.org

Refer to Bug 64251 - resizing mail preview garbles MIME-Tree display
Diff

Scott Wheeler committed a change to kdepim/kmail

Select folders on mouse release rather than mouse press.  This prevents one
folder showing up as selected in the folder listview and another set of
messages showing up in the message list (if you click on one folder and
release on another).

CCMAIL:68694-done@bugs.kde.org

Refer to Bug 68694 - Selecting folder and then dragging to another leaves display inconsitent
Diffs: 1, 2

Cornelius Schumacher committed a change to kdepim/kmail

Correctly pass iCalendar attachments to KOrganizer. This replaces the
functionality of the korganizerIn script. Patch reviewed by Bo.

CCMAIL: 68332-done@bugs.kde.org

Refer to Bug 68332 - Actions shown in message view for iCalendar attachments don't work
Diffs: 1, 2

Carsten Burghardt committed a change to kdepim/kmail

This should fix 69004, 69157, 68992
Can anybody confirm this?

CCMAIL: 69004@bugs.kde.org
CCMAIL: 69157@bugs.kde.org
CCMAIL: 68992@bugs.kde.org

Refer to Bug 69004 - another crash in kacctimap
Refer to Bug 69157 - crash while drag'n'dropping messages
Refer to Bug 68992 - kmail crashes if actions are performed during imap download
Diff

Tobias Koenig committed a change to kdepim/knode

Don't keep pointers of KXMLGUIBuilder created QPopupMenus, they get invalid
when switching between parts.
That fixes #67007.

CCMAIL:67007-done@bugs.kde.org

Refer to Bug 67007 - knode  in kontact crashes on context menu
Diffs: 1, 2, 3, 4, 5, 6

Richard Lärkäng committed a change to kdepim/knode

Run prepareShutdown also when closing if run from Kontact.
Needed because otherwise it won't cleanup and save the state
of the messages (read/unread etc)

Approved by Roberto Selbach Teixeira

CCMAIL: 67626-done@bugs.kde.org

Refer to Bug 67626 - When Kontact closes Knode doesn't perform cleanup
Diffs: 1, 2

Reinhold Kainhofer committed a change to kdepim/kontact/plugins/korganizer

Hide completed todos in Kontact's summary view. 
Okay'ed by Cornelius.

CCMAIL: 67981-done@bugs.kde.org

Refer to Bug 67981 - Done Todo's appear in section appointments in summary view
Diff

Tobias Koenig committed a change to kdepim/kontact/plugins/summary

Use aboutData in the part, so the bug report dialog selects the correct
component.
That fixes #68967.

CCMAIL:68967-done@bugs.kde.org

Refer to Bug 68967 - kontactsummary not in bugs database
Diffs: 1, 2, 3

Tobias Koenig committed a change to kdepim/kontact/src

Clear the status bar whenever a new part is selected.

CCMAIL:67954-done@bugs.kde.org

Refer to Bug 67954 - status bar not updated when changing between parts in kontact
Diff

Tobias Koenig committed a change to kdepim/kontact/src

Add 'Configure Toolbars' action. That fixes #67174.

CCMAIL:67174-done@bugs.kde.org

Refer to Bug 67174 - Cannot configure plugin toolbars while in kontact
Diffs: 1, 2, 3

Tobias Koenig committed a change to kdepim/korganizer

Don't store pointers of XMLGUIBuilder created popupmenus, they get invalid
when switching between parts.
That fixes #67362.

CCMAIL:67362-done@bugs.kde.org

Refer to Bug 67362 - kontact crashs after right click on calendar
Diffs: 1, 2

Tobias Koenig committed a change to kdepim/korganizer

Add the static KOGlobals::mConfig as a member variable and delete this with
a static deleter, so mConfig->sync() is called implicitely.
That fixes #68339.

CCMAIL:68339-done@bugs.kde.org

Refer to Bug 68339 - KOrganizers "show filter" setting isn't remembered in Kontact
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11

Reinhold Kainhofer committed a change to kdepim/kpilot/kpilot

Unbreak the conduit configuration dialog: We need to remove the old widget from the 
widget stack before we can insert another widget at the same position. Also, apply 
now works, and cancelling switching between conduits (if you changed anything, you 
are asked if you want to save the changes: yes/no/cancel) now has the correct selection 
behaviour in the list.

CCMAIL: 67323-done@bugs.kde.org

Refer to Bug 67323 - Can only configure one conduit at a time
Diffs: 1, 2

Koffice

Bugfixes

Rob Buis committed a change to koffice/karbon/widgets

Fix for bug #69203.

Refer to Bug 69203 - crash after canceling 'open new doc'
Diff

Konqueror

Features

Stephan Kulow committed a change to kdelibs/khtml

as discussed: merging in Safari's code for parseFontFamily. The way it was done
in webcore, didn't fit 100% as our FontFamilyValueImpl constructor does some
work, that the parseFontFamily didn't take in account 

I also removed the code that checked if a font is the same by doing substring
comparision, leading to rather random font choices (e.g. sans -> comic sans)

Diffs: 1, 2, 3
Bugfixes

Waldo Bastian committed a change to kdebase/kcontrol/konqhtml

Fallback to khtmlrc, just like khtml does, when settings are not available
in konquerorrc. (BR64591)
CCMAIL: 64591-done@bugs.kde.org

Refer to Bug 64591 - Minimum Font Size not correct when missing from settings file
Diffs: 1, 2

Stephan Binner committed a change to kdebase/konqueror

Fixed "Bug 58038: web-pages open in wrong tabs (normal)"
Reviewed by David

Refer to Bug 58038 - web-pages open in wrong tabs
Diff

Stephan Binner committed a change to kdebase/konqueror

Better fix for #67956 which also works with background tabs from sidebar
David didn't object. :-)

Refer to Bug 67956 - opening a postscript file in a background tab causes konqueror to become confused
Diff

George Staikos committed a change to kdebase/nsplugins

patch from Koos to add better javascript support
CCMAIL: 65868-done@bugs.kde.org

Refer to Bug 65868 - Flash content missing
Diffs: 1, 2, 3

Germain Garand committed a change to kdelibs/khtml

- do not use DirWS to count spaces when justifying, it wouldn't count  's (#65903)
- implement missing DOM method

Reviewed by Dirk
					

Refer to Bug 65903 - The &nbsp breaks align "justify"
Diffs: 1, 2, 3, 4

Stephan Kulow committed a change to kdelibs/khtml

slightly modified patch by Paul Sprakes to fix his own bug report which 
turned out to be a regression introduced by my fix for #60556 (see #67768
for detailed descriptions)

(will work out regression tests now :)

Refer to Bug 60556 - Konqueror doesn't parse font-family CSS correctly if first font doesn't exist [testcase]
Refer to Bug 67768 - PATCH: Konqueror picks wrong font from face attribute
Refer to Bug 67973 - [test case] Font changing on a:hover
Diffs: 1, 2

Germain Garand committed a change to kdelibs/khtml

- don't create an image renderer if our parent doesn't
allow childs. e.g: a RenderPartObject

reviewed by Dirk

CCMAIL: 66793-done@bugs.kde.org

Refer to Bug 66793 - Crash on libpng test site
Diffs: 1, 2

Stephan Kulow committed a change to kdelibs/khtml

handle invalid font families (as discussed with Dirk I'm commiting my version
of the patch and will after that try to merge the safari code to handle even
more cases)
(this problem is the cause of many bug reports, I'm just picking one :)
CCMAIL: 67348-done@bugs.kde.org

Refer to Bug 67348 - Font selection in HTML gives unexpected results
Diffs: 1, 2

David Faure committed a change to kdelibs/khtml

Fixed infinite loop with <nobr> due to findNextLineBreak going back (wrong variable used).
Regression tested.
CCMAIL: 66867-fixed@bugs.kde.org, 68598-fixed@bugs.kde.org

Refer to Bug 66867 - [test case] konqueror hangs while trying to open www.burdaworld.de
Refer to Bug 68598 - nobr and br in table may cause infinite loop (www.snopes.com) (testcase)
Diffs: 1, 2

David Faure committed a change to kdelibs/khtml

The popInlineBlocks infinite loop fix also fixes 59230.
CCMAIL: 59230-fixed@bugs.kde.org

Refer to Bug 59230 - sonnenklar.tv/index.html javascript hangs konqueror 3.1.(0-2)
Diff

Germain Garand committed a change to kdelibs/khtml

- as discussed on kfm-devel: add an Automatic Detection mode  in the 
  "Use Stylesheet" menu. In this mode, the preferred sheet is chosen 
  by the document, following the standard rules of precedence. 
  If another sheet is manually chosen, then it gains a higher precedence
  and overrides the document's choice, thus becoming "sticky".
  
- for manually chosen sheets: if the wanted stylesheet is still missing after
  <body> has been parsed, choose the document's preferred stylesheet until
  parsing ends(#63348).

CCMAIL: 54335-done@bugs.kde.org
CCMAIL: 63348-done@bugs.kde.org

Refer to Bug 63348 - Konqueror looses style sheets on kde.org and gentoo.org
Refer to Bug 54335 - Konqueror 3.1: first alternate CSS stylesheet replaces default stylesheet. Javascript can't change style
Diffs: 1, 2, 3

David Faure committed a change to kdelibs/khtml

Implement hasProperty and get for frames by number in Window,
to fix window[0] and parent[1] etc. (#56983)
Reviewed by Harri - thanks to Maksim for the testcase.
CCMAIL: 56983-fixed@bugs.kde.org

Refer to Bug 56983 - [Testcase] parent[something] support in framesets lacking (http://the-sun.com.hk)
Diffs: 1, 2

Stephan Kulow committed a change to kdelibs/khtml

take out the isInline() from height calculation for replaced. Very bad regression
and if we had a working khtmltests two months ago... 
CCMAIL: 67839-done@bugs.kde.org

Refer to Bug 67839 - [test case] Image with "float" css style property don't show up (regression)
Diffs: 1, 2

Stephan Kulow committed a change to kdelibs/khtml

fixing <body link="00ccff"> regression in syncing the function with safari
CCMAIL: 67903-close@bugs.kde.org

Refer to Bug 67903 - [test case] link="00ccff" not recognized as color (regression)
Diffs: 1, 2

Dirk Mueller committed a change to kdelibs/khtml

* css/html4.css: Set quirky margins on elements that need it (#66490).
CCMAIL: 66490-done@bugs.kde.org

Refer to Bug 66490 - [test case] <P> in TDs cause extra spacing (regression)
Diffs: 1, 2, 3

Stephan Kulow committed a change to kdelibs/khtml

don't let images overwrite the previous content
CCMAIL: 67373-fixed@bugs.kde.org

Refer to Bug 67373 - [test case] links don't show up on this page (regression)
Diffs: 1, 2

Dirk Mueller committed a change to kdelibs/khtml

       * html/htmlparser.cpp (parseToken): ignore flat on <select>. maybe
       we should only do this in compat mode though (#69017).

Refer to Bug 69017 - [test case] <select/><option>...</option></select> has empty combobox
Diffs: 1, 2

Germain Garand committed a change to kdelibs/khtml

 don't crash when toggling stylesheets via scripts

 reviewed by Dirk

CCMAIL: 67453-done@bugs.kde.org
CCMAIL: 68504-done@bugs.kde.org

Refer to Bug 67453 - khtml: assertion failed in DOM::DocumentImpl::styleSheetLoaded()
Refer to Bug 68504 - page thinksecret.com crashes Konqueror
Diffs: 1, 2, 3, 4

David Faure committed a change to kdelibs/khtml/html

Fix for infinite loop in popInlineBlocks(). This is because 
popOneBlock returns immediately if blockStack==0). Approved by Dirk.
It's the day for busting infinite loops :)
CCMAIL: 68034-done@bugs.kde.org

Refer to Bug 68034 - <nobr><table></table></nobr> + getElementById + innerHTML = hang!? (regression)
Diff

Koos Vriezen committed a change to kdelibs/khtml/java

KJAS side of bug #68557, rest is ecma not getting window.parent.framename right
- JS from java might contain unicode, so use a byte array to get the length right
- escape newlines also in JS

Refer to Bug 68557 - java chat doesn't display
Diffs: 1, 2, 3

Multimedia

Features

Max Howell committed a change to kdenonbeta/amarok

* New optional feature: "Resume playback", which means that playback will resume 
  where it left off last time you quit amaroK when you start it up again, in the 
  few hours since implementing it, I have grown to absolutely adore this feature! :-) 
  But then again, when developing amaroK you do have to start and stop it frequently, 
  so it is perfect for me
* While I was making new options, I fixed the fontsizes-not-updating-in-options-dialog 
  bug, did a "reduce LOC, improve readability" on the options dialog source, attempted 
  to improve clarity and substance of the options UI and added some "what is this" tips. 
  I didn't go overboard, just tried to implement a better base for future expansion.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14

Max Howell committed a change to kdenonbeta/amarok/amarok

* Well here it is. StreamBrowser extension for amaroK. I've completely stolen 
  (GPL don't panic!) KDERadioStation's code and allowed amaroK to recieve DnD from 
  the widget. As yet I haven't told the author of KDERadioStation, but if we agree 
  to pursue this I'll ask and tell. Enjoy by dragging and dropping streams to the 
  playlist. Note, this is buggy, ignore amaroK's complaint about the URL, it'll work. 
  Also some streams don't work for some reason. Also one stream tried to d/l a 42MB 
  playlist! So it's buggy, be warned.
* Also I've broken the playlist a little to do this/because I was in the middle of 
  something else. I've made it so you sort as typical in the rest of KDE (click on 
  the column headers), and made it so you can still add stuff to the middle of the 
  playlist. But there are a few bugs. Fixing this stuff is next on my list.
* If you want to integrate/fix/amend/discuss the stream browser please do. I've 
  committed so we can discuss where this is heading.

Diffs: 1, 2, 3
Bugfixes

Scott Wheeler committed a change to kdeextragear-2/taglib/ogg

Don't assume that the second and thrid packets of a vorbis stream are always
completely contained on the second page of the Ogg stream.  While the current
xiph libraries attempt to make this the case pre-1.0 libogg did not.

CCMAIL:68627-done@bugs.kde.org

Refer to Bug 68627 - Corruption of ogg vorbis files while attempting to add tags
Diffs: 1, 2, 3

Scott Wheeler committed a change to kdemultimedia/juk

For reasons that I don't understand QSpinBox doesn't emit a valueChanged()
signal when the text is changed by the keyboard (though this is obviously
intentional from reading the QSpinBox code).  So, fake it here.

CCMAIL:69061-done@bugs.kde.org

Refer to Bug 69061 - Tracks & Years don't save with Ctrl-T
Diffs: 1, 2

Scott Wheeler committed a change to kdemultimedia/juk

Fixed autocompletion on the genre list.  Update the list of autocompleted
items when a new name (i.e. one not already in the autocompletion list)
is enterered.

CCMAIL:69116-done@bugs.kde.org

Refer to Bug 69116 - No autocomplete on Genre & Artist/Albums not updating auto-complete list
Diffs: 1, 2, 3, 4, 5, 6, 7, 8

Allan Sandfeld Jensen committed a change to kdemultimedia/kioslave/audiocd

Fixing a handfull of bugs:
 - bug 60069 Songs too short after encoding (thanks to toojays for patch)
 - bug 63238 Error ripping files with "/" in their name (renaming slashes to %2F 
   was already present but not consistent).
 - Set correct title in id3 and ogg-comments

Refer to Bug 60069 - Songs too short after encoding
Refer to Bug 63238 - error ripping files with "/" in their name
Diffs: 1, 2

Christian Esken committed a change to kdemultimedia/kmix

Size and resize of panel applet corrected: Fix #66064 (Thanks to Andras Mantia)
Hide/show channels corrected: Fixing #64441 (Hint and prototype patch by Andras 
Mantia, real patch by Christian Esken)

Refer to Bug 66064 - kmix kicker applet has too "spacy" layout
Refer to Bug 64441 - Does not remember hidden channels
Diffs: 1, 2, 3

Christian Esken committed a change to kdemultimedia/kmix

Layout trouble resolved (menu bar hiding on start). Slightly related to #64440 and #49142

Refer to Bug 64440 - Wrong layout after session restore
Refer to Bug 49142 - kmix always start non-iconified regardless on how it was when session was saved
Diff

Christian Esken committed a change to kdemultimedia/kmix

Fix Bug #64274 (KMix system tray icon shows absurd volume number 24119703%) and remove debug output.

Refer to Bug 64274 - KMix system tray icon shows absurd volume number 24119703%
Refer to Bug 24119 - No K-menu on desktop
Diff

Christian Esken committed a change to kdemultimedia/kmix

Won the record-source-setting battle. Fixing Bug #64438 partly: You can now set the record source.

Refer to Bug 64438 - Input-mixer doesn't support switching the recording source
Diff

Christian Esken committed a change to kdemultimedia/kmix

ALSA is now usable. Fixing Bug #64438 partly (full fix is too complicated and must wait after KDE3.2)

Refer to Bug 64438 - Input-mixer doesn't support switching the recording source
Diffs: 1, 2

Richard Lärkäng committed a change to kdemultimedia/libkcddb

Only set the username if it isn't empty. Fixes sending of cddb-information if
smtp-server doesn't need authentication

CCMAIL: 68906-done@bugs.kde.org

Refer to Bug 68906 - cddb submission via smtp does not work
Diff

Networking Tools

Features

Sebastian Sauer committed a change to kdeextragear-2/kmldonkey

Here we go with a bigger commit to start creating an api to
support multiple (gui-)protocols. I decided to go this way
instat of a complete lib-rewrite to keep compatibility. Also
changed some smaller other stuff like my author-mail-addy.
Guess it's good to start that way to get it working some
day - more follows and comments are welcome ;)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 
21
Security

Jean-Baptiste Mardelle committed a change to kdeutils/kgpg

remove ability to create ElGamal only keys due to a major security issue in GnuPG.
see: http://lists.gnupg.org/pipermail/gnupg-announce/2003q4/000276.html

Diffs: 1, 2
Bugfixes

Will Stephenson committed a change to kdenetwork/kopete/kopete/contactlist

Fixed in CVS.  Thanks bilson for spotting this.

CCMAIL: 68695-done@bugs.kde.org

Refer to Bug 68695 - renaming MCs with F2 doesn't call KMC::setDisplayName()
Diff

Jason Keirstead committed a change to kdenetwork/kopete/libkopete

Fix typo resulting in missing display name

CCMAIL:68674-done@bugs.kde.org

Refer to Bug 68674 - MetaContactDisplayName don't work on incoming message
Diff

Till Gerken committed a change to kdenetwork/kopete/protocols/jabber

Temporarily fixing the incorrect display of typing notifications as empty
messages. Full support will be added after the 3.2 release.
CCMAIL: 67663-done@bugs.kde.org, kopete-devel@kde.org

Refer to Bug 67663 - Jabber plugin not support JEP-0022
Diff

Matt Rogers committed a change to kdenetwork/kopete/protocols/yahoo

Fix bugs 66920 and 67287. Both were basically due to my not making sure 
things were cleaned up correctly.

Sent to the list for review and received absolutely no comments on it.
Assuming it's good.

CCMAIL: 67287-done@bugs.kde.org
CCMAIL: 66920-done@bugs.kde.org

Refer to Bug 66920 - Yahoo does not connect cleanly
Refer to Bug 67287 - yahoo plugin goes offline without notification; status shown as online
Diffs: 1, 2

User Interface

Bugfixes

Chris Lee committed a change to kdeartwork/styles/dotnet

Bugfix for #67730 (long text overlaps button edges) as well as for a bug where 
some pixels from the scrollbar handle weren't being repainted properly.

-clee

Refer to Bug 67730 - Long text overlaps button edges in dotNet style
Diffs: 1, 2

Oliver Bausinger committed a change to kdebase/kicker/applets/minipager

kicker applet transparency fixes (#64707)

- fix the background mode of the pager in transparent mode

Refer to Bug 64707 - PATCH: kicker transparency problems / errors
Diff

Luboš Luňák committed a change to kdebase/kwin

Attempt number 3251 at finally fixing #67914. This window grouping
will have to be reworked for 3.3.

Refer to Bug 67914 - Konqueror Scan Plugins crashes kwin
Diff

Luboš Luňák committed a change to kdebase/kwin

Fix #65279 - make sure windows hidden by apps are really hidden.
The problem was visible even with { widget.show(); widget.hide(); }.

Refer to Bug 65279 - some windows remain after being closed by the application (kio_uiserver)
Diffs: 1, 2

Luboš Luňák committed a change to kdebase/kwin

Compress MotionNotify events while user moving/resizing, this should
make opaque resizing acceptable again, close #67471, and stop people
complaining.

Refer to Bug 67471 - Window redraw horrible when moving / resizing window
Diff

Luboš Luňák committed a change to kdebase/kwin

People have strange ideas ... filter out unprintable characters from window
captions.
CCMAIL: 68882-done@bugs.kde.org

Refer to Bug 68882 - QWidget::setCaption doesn't filter newlines
Diff

Luboš Luňák committed a change to kdebase/kwin

Fix #69005 - make it possible to differentiate between a window really
being shaded and being set to be shaded (which may differ with hover unshade).

Refer to Bug 69005 - Shade context menu action always off if 'Enable hover'/'auto-unshade' is turned on
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9

Luboš Luňák committed a change to kdebase/kwin

checkGroupTransients() uses hasTransient() to break loops, so it must detect them,
fixes #69094

Refer to Bug 69094 - kwin crashes while searching in adobe acrobat reader
Diffs: 1, 2

Tobias Koenig committed a change to kdelibs/kdeui

Use iconSet when available in KToolBarPopupAction, otherwise the wrong
icons are loaded when actions from different parts (instances) are plugged in.

CCMAIL:67450-done@bugs.kde.org

Refer to Bug 67450 - Kontact does not load the correct icons for new mail, todo, event, etc... in the Kontact toolbar
Diff

Tobias Koenig committed a change to kdelibs/kdeui

Make the actions icons in konqueror visible again.

CCMAIL:68770-done@bugs.kde.org

Refer to Bug 68770 - back, forward, and up icons always missing on toolbar
Diff

Zack Rusin committed a change to kdelibs/kdeui

Initially the dialog is hidden, due to which it wasn't showing up when the
first paragraph in the text didn't contain any misspellings. I was thinking of
something silly to put in the log, but kspell hacking is wrecking me, so
lets just rejoice that another major bug is closed.
CCMAIL: 69059-done@bugs.kde.org

Refer to Bug 69059 - Various spell-checker problems in applications
Diff

Utilities

Bugfixes

Jeroen Wijnhout committed a change to kdeextragear-2/kile/kile

fix Bug 68890: clean fails on Document whith filenames, that include whitespaces

Refer to Bug 68890 - clean fails on Document whith filenames, that include whitespaces
Diff

Alexander Kellett committed a change to kdelibs/kio/bookmarks

remove the ugly managerForFile hack with a non written to file, 
   this makes me feel a whole lot happier with the code.
two wrapper macros: CURRENT_MANAGER and CURRENT_TOOLBAR to abstract the m_filteredMgr override.
fix 67787 by using CURRENT_MANAGER abstraction for submenus.
write a future note for that date in the future where non-read only filtered bookmark menus are supported.
(note, these are obvious fixes, so anything that i've broken is just 
 gonna segv rather than giving quite random behaviour like it was, well, 
 sue me, no not really, i'm only joking... yummy wonderful wine this is)

Refer to Bug 67787 - Bookmark toolbar shows wrong folder contents
Diff


Thanks for reading KDE-CVS-Digest