KDE-CVS-Digest

Weekly View of KDE CVS commits

January 10, 2003

By Derek Kite

This Week:

Apple Safari uses khtml, merge of Apple contributions, Krdc features and numerous bug fixes.

Many thanks to Melchior Franz for suggestions and help with html and favicons. It's easy to find an answer when you know the question. If some kind soul would like to draw an icon I could use as a shortcut icon, it would be much appreciated. I swiped one from the kde icon packages. Not very original.

Apple Safari
Tim Jansen on Krdc

Bugfixes	New Features
Ark	Porting
Atlantik	Arts
Kabc	K3b
Kaddressbook	Kaplan
Kalarm	Kcalendar
Kappfinder	Kde-i18n
Kcontrol	Kdebindings
KdeJava	Kdecore
Kdeprint	Kdeui
Kdesdk	Kdevelop
Kdevelop	Keduca
Kio	Kio
Klipper	Klaptopdaemon
Kmail	Kmail
Kmplot	Koffice
Knode	Konqueror
Koffice	Kopete
Konqueror
Konsole
Kopete
Korganizer
Ksirc
Kwin

Apple Safari

Big news from Apple. There have been rumors of Apple developing a web browser. At Macworld Expo San Francisco Steve Jobs introduced Safari. The web page says "Safari offers you a superior Web experience with outstanding performance. Even the most complex of pages load at breakneck speed.". The real surprise is "For its Web page rendering engine, Safari draws on software from the Konqueror open source project. Weighing in at less than one tenth the size of another open source renderer, Konqueror helps Safari stay lean and responsive. And of course, being a good open source citizen, Apple shares its enhancements with the Konqueror open source community." And being true to their word, Dirk Mueller received an email which he posted on kfm-devel.

I'm the engineering manager of Safari, Apple Computer's new web browser 
built upon KHTML and KJS. I'm sending you this email to thank you for 
making such a great open source project and introduce myself and my 
development team. I also wish to explain why and how we've used your
excellent technology. It's important that you know we're committed to 
open source and contributing our changes, now and in the future, back 
to you, the original developers. Hopefully this will begin a dialogue 
among ourselves for the benefit of both of our projects.

I've "cc"-ed my team on this email so you know their names and contact 
information. Perhaps you already recognize some of those names. Back 
in '98 I was one of the people who took Mozilla open source. David
Hyatt is not only the originator of the Chimera web browser project but
also the inventor of XBL. Darin Adler is the former lead of the
Nautilus file manager. Darin, Maciej Stachowiak, John Sullivan, Ken
Kocienda, and I are all Eazel veterans.

The number one goal for developing Safari was to create the fastest web 
browser on Mac OS X. When we were evaluating technologies over a year 
ago, KHTML and KJS stood out. Not only were they the basis of an
excellent modern and standards compliant web browser, they were also 
less than 140,000 lines of code. The size of your code and ease of
development within that code made it a better choice for us than other 
open source projects. Your clean design was also a plus. And the
small size of your code is a significant reason for our winning startup 
performance as you can see reflected in the data at 
http://www.apple.com/safari/ .

How did we do it? As you know, KJS is very portable and independent.
The Sherlock team is already using it on Mac OS X in the framework my 
team prepared called JavaScriptCore. But because KHTML requires other
components from KDE and Qt, we wrote our own adapter library called KWQ
(and pronounced "quack") that replaces these other components. KHTML
and KWQ have been encapsulated in a framework called WebCore. We've
also made significant enhancements, bug fixes, and performance 
improvements to KHTML and KJS.

Both WebCore and JavaScriptCore, which account for a little over half 
the code in Safari, are being released as open source today. They
should be available at 
http://developer.apple.com/darwin/projects/webcore/ very soon. Also,
we'll be sending you another email soon which details our changes and 
additions to KHTML and KJS. I hope the detailed list in that email
will help you understand what we've done a little better. We'd also
like to send this information to the appropriate KDE mailing list.
Please advise us on which one to use.

We look forward to your comments. We'd also like to speak to you and
we'd be happy to set up a conference call at our expense for this 
purpose.

Thank you again for making KHTML and KJS.

Please forward this email to any contributor whom I may have missed.

Don Melton
Safari Engineering Manager
Apple Computer

Dirk Mueller responded:

I hope so too. I'm deeply impressed by your detailed changelog and by 
the changes. A few of the changes have already happened in "our" developing 
version and many of them were on our TODOs. For example just about this 
weekend I was working on improving the kjs garbage collector and now I read 
that you apparently already fixed the issues I had with it. Seems to me like 
a huge christmas gift. Thank you. Thanks a lot. 

Especially I'd like to hope that we could set up a mailing list where we 
could exchange ideas, patches and bug reports. Also a common testsuite for 
regressions would be nice and probably help us a lot in developing KHTML and 
KJS further. Ideally the plan should be, and I hope you agree, to use a 
common codebase for the backend.

You will see in the Konqueror section below a number of patches that have been included in the kde repository. It is worthwhile looking at the changes to see the amount of work that has been contributed.

Tim Jansen on Krdc

Tim Jansen brought to my attention that Krdc, the Kde remote desktop client:

Until last week, krdc was limited to VNC as protocol. Now it is on its way to 
become a multi-protocol client.
It started when Arend van Beelen jr. sent a patch to start rdesktop 
(www.rdesktop.org) when a rdp: URL is entered. RDP is the protocol used by 
Windows for the Windows Terminal Services, basically Microsoft's equivalent 
to VNC, and rdesktop is a free (non-GUI) viewer for it. 
He was also interested in writing a native backend based on rdesktop, so I 
started moving the VNC-specific code into its own directory and created a 
protocol-indepent layer between the GUI frontend and the protocol backend. 
He's currently working on the backend (not in CVS) and has sent some patches 
to improve the abstraction layer (in CVS).

Bug Fixes

Ark

Hans Petter Bieker committed a change to kdeutils/ark

Fixed bug 52219 and 52219.

Refer to Bug 52219 - Ark doesn't use KLocale to format dates
Diffs: 1, 2, 3

Helio Chissini de Castro committed a change to kdeutils/ark

- Large cleanup and modifications by Georg Robbers. Many thanks to him.
- Relevant changes:
- factor out the MainWindow functionality of ArkWidget into the new class   
ArkTopLevelWindow
- Made ArkTopLevelWindow use the part
- made the part use the arkwidget (so the part now has all the functionality of 
the old arkwidget)
- made it possible to start the part in readonly mode (for Konqueror) and in 
readWrite mode (for the 'real' Ark)
- moved the action handling code to the part and the ArkToplevelWindow 
respectively
- since Konqi can embbed more than one ArkPart at once, the pid() approach for 
the temp directory didn't work anymore, since those had all the same pid - 
the one of the Konq they were embedded in - now every ark part creates an own 
temp dir based on a random number - this is open for discussion though :-)
- many small things all over the place which I don't rember all of 'em (like 
make the ArkApplication use KURLs instead of QStrings to keep track of 
already open arks)
Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 
21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 
41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51

Atlantik

Rob Kaper committed a change to kdegames/atlantik

fixed 52214 (in monopd)

Refer to Bug 52214 - player name change doesn't make it into game description
Diff
Backported to KDE_3_1_BRANCH.
Diff

Rob Kaper committed a change to kdegames/atlantik

bugfix wrt utf-8 handling (52644)

Refer to Bug 52644 - Japanese text mangled by the game
Diffs: 1, 2, 3, 4
Backported to KDE_3_1_BRANCH
Diffs: 1, 2, 3, 4

Rob Kaper committed a change to kdegames/atlantik

fix http://bugs.kde.org/show_bug.cgi?id=52529
Diffs: 1, 2
Backported to KDE_3_1_BRANCH.
Diff

Rob Kaper committed a change to kdegames/atlantik

fix http://bugs.kde.org/show_bug.cgi?id=52774
Diffs: 1, 2, 3, 4, 5, 6, 7

Kabc

Ian Reinhart Geiser committed a change to kdelibs/kabc/plugins/ldap

Fixes for solaris, these did not seem to make it into 3.1 but really 
should have been... for that matter i cannot clearly remember if i posted 
this patch to the list so its probibly my fault :P CCMAIL:mueller@kde.org 
Diffs: 1, 2, 3

Kaddressbook

Laurent Montel committed a change to kdepim/kaddressbook

Fix crash when there is not active view
Diff
Backported to KDE_3_1_BRANCH.
Backport fix crash when active doesn't exists
Diff

Kalarm

David Jarvie committed a change to kdepim/kalarmd

Fix bug 52659: alarms not being triggered if KAlarm is not running

Refer to Bug 52659 - Alarms don't appear until KAlarm is run manually
Diffs: 1, 2
Backported to KDE_3_1_BRANCH.
Replace system() with KProcess
Diff

Kappfinder

Stephan Binner committed a change to kdebase/kappfinder

Always make all buttons visible (51834).

Refer to Bug 51834 - Initial window too small to see Scan button - very minor problem
Diff
Backported to KDE_3_1_BRANCH.
Diff

Kcontrol

Helge Deller committed a change to kdebase/kcontrol/info

CCMAIL:52640-done@bugs.kde.org
Fix default font usage of listbox headers, closes bug 52640.

Refer to Bug 52640 - text font and i18n() problems
Diff

Helge Deller committed a change to kdebase/kcontrol/info

CCMAIL:52640-done@bugs.kde.org
i18n changes: fix singular/plural forms of Bit/Bits & Byte/Bytes,
closes BR52460

Refer to Bug 52460 - konq renders HTML painfully slow (pages like bugs.kde.org)
Diff
Backported to KDE_3_1_BRANCH.
Fix default font usage of listbox headers, closes bug 52640.
Diff

Daniel Molkentin committed a change to kdebase/kcontrol/kio

Finally fix 23883 using a slightly adopted patch provided by Georg Robbers.
Thanks to KProcess::detach() we won't need the createServiceByPath() approach
to ensure kio_http_cache_cleaner continues even when the applet is closed.
CCMAIL23883-done@bugs.kde.org

Refer to Bug 23883 - clear cache does not clear cache
Diffs: 1, 2
Backported to KDE_3_1_BRANCH.
fix for 23883 (backport)
Diffs: 1, 2

KdeJava

Harri Porten committed a change to kdelibs/kjs

started with a trivial part of Apple's performance improvements:
removed the (empty) destructors of all nodes.
Diffs: 1, 2

Kdeprint

Michael Goffioul committed a change to kdelibs/kdeprint/lpr

Fix (trivial) for bug 52605: avoid to pass application options on the LPRng command-line

Refer to Bug 52605 - kdeprint not working on 3.1.x but works with 3.0.x (lprng)
Diffs: 1, 2, 3
Backported to KDE_3_1_BRANCH.
Fix (trivial) for bug 52605: avoid to pass application options on the LPRng command-line
Diffs: 1, 2, 3

Kdesdk

Stanislav Visnovsky committed a change to kdesdk/kbabel/kbabel

Fix 52691: after merging the settings should be considered valid.

Refer to Bug 52691 - KBabel doesnt save Spell Checker settings
Diff

Kdevelop

Harald Fernengel committed a change to kdevelop/parts/classview

this should finally fix the crashes when saving files while the classview is opened.
I know it is a bit slower now since we copy the items instead of keeping pointers
but at least we don't get dangling pointers.
I also messed around with smart pointers but the problem is that the ListViewItems
sometimes get killed before the ParsedItems and vice versa so I would have needed
a manager class which would be slow as well so I decided to use the copying approach.
Diffs: 1, 2

Kio

Waldo Bastian committed a change to kdebase/kioslave/devices/kdedmodule

CCMAIL:51470-done@bugs.kde.org
Don't hang on cyclic symlinks

Refer to Bug 51470 - kde not starting (high kded cpu usage starting mountwatcher)
Diff
Backported to KDE_3_1_BRANCH.
Diff

Carsten Burghardt committed a change to kdebase/kioslave/imap4

The mailboxname exists only once, so break
Diff
Backported to KDE_3_1_BRANCH.
The mailboxname exists only once, so break
Diff

Waldo Bastian committed a change to kdelibs/kio/kio

CCMAIL:52612@bugs.kde.org
Don't crash when KExtendedSocket::peerAddress() fails.

Refer to Bug 52612 - kio_http connection problems with socks
Diff
Backported to KDE_3_1_BRANCH.
Don't crash when KExtendedSocket::peerAddress() fails.
(backport)
Diff

Klipper

Dirk Mueller committed a change to KDE_3_0_BRANCH: kdebase/klipper

fix uninit mem read (backport)
Diff

Dirk Mueller committed a change to KDE_3_1_BRANCH: kdebase/klipper

argh. brown paper bag please
Diff

Kmail

Ingo Klöcker committed a change to KDE_3_1_BRANCH: kdenetwork/kmail

Fix Bug52673: Composer empty when started with 'kmail --msg <file>'
and don't crash if <file> can't be read.

Refer to Bug 52673 - KMail editor non recive the text
Diffs: 1, 2

Kmplot

Caleb Tennis committed a change to kdeedu/kmplot/kmplot

Applying fix for compiling on Solaris, clears up bug 50702 - by bmlmessmer@web.de

Refer to Bug 50702 - `isinf' undeclared on Solaris 2.6
Diff
Backported to KDE_3_1_BRANCHApplying fix for compiling on Solaris, clears up bug 50702 - by bmlmessmer@web.de (backport)
Diff

Knode

Christian Gebauer committed a change to kdenetwork/knode

fix for 52553, as suggested by the reporter

Refer to Bug 52553 - [PATCH] Newsgroups header must not contain spaces (so let's remove them)
Diff
Backported to KDE_3_1_BRANCH.
backport of fix for 52553
Diff

Christian Gebauer committed a change to kdenetwork/knode

fix for 52163:
the links now have the configured color

Refer to Bug 52163 - link colour not used
Diff

Christian Gebauer committed a change to kdenetwork/knode

* fix for 51558 (alternative list background color didn't work)
 <=>
* remove the inheritance of KNListView to KFolderTree for now
  because there is no code reuse at all and I can't imagine that
  there could be any in the case of the header view.
  So its just a waste of memory & cpu cycles

Refer to Bug 51558 - KNode ignores my alternate list color
Diffs: 1, 2, 3
Backported to KDE_3_1_BRANCH.
backport of the bugfix for 51558 (alternate list backgrounds)
Diffs: 1, 2, 3

Christian Gebauer committed a change to kdenetwork/knode

fix for 51856 and part of 51856
... the url parsing code in knarticlewidget sucks!

Refer to Bug 51856 - "|" does not count as a URL character -> clicking on URLs doesn't work
Diff

Christian Gebauer committed a change to KDE_3_1_BRANCH: kdenetwork/knode

backport of the fix for 52023

Refer to Bug 52023 - Load Group List Crash
Diff

Koffice

Nicolas Goutte committed a change to koffice/filters/kword/rtf/oldexport

No space between font name and ;
CCMAIL:52609@bugs.kde.org

Refer to Bug 52609 - rtf exporting loses some of the formattings
Diff

Laurent Montel committed a change to koffice/karbon/tools

Fix crash.
But there is again a crash when we select clipart tool
and we click on "karbon page"
Diff

Philipp Müller committed a change to koffice/kchart/pics

Added 2 pics for the wizard. Fixes 44482 (normal): Graphics missing in KChart wizard
I'm no artist, but these are better than none ;-)

Refer to Bug 44482 - Graphics missing in KChart wizard
Diffs: 1, 2, 3

Philipp Müller committed a change to koffice/kspread

Fix crash when trying to insert an embedded chart.
The change to KoQueryTrader was BIC. 
Additional to the original function in KoQueryTrader
  query( const QString &  _constr = QString::null )
the new function
  query( bool _onlyDocEmb /*=true */,const QString& _constr = QString::null );
was added.
But there is (at least for my compiler gcc 2.95.4) no difference 
between both, when simply called query("something"), so in the 
actual case the new query was called (the argument qstring was then 
null, which lead to an unfiltered list and therefore to the crash).
The change I added to kspreadview.cc can stay even after the BC fix.
I didn't touch koquerytrader as I leave this to the original author.
CCMAIL: kde@jowenn.at
Diff